Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple testcafe from recink and move it into new component #117

Closed
eistrati opened this issue Jan 15, 2018 · 5 comments
Closed

Decouple testcafe from recink and move it into new component #117

eistrati opened this issue Jan 15, 2018 · 5 comments
Assignees

Comments

@eistrati
Copy link
Contributor

eistrati commented Jan 15, 2018

  • framework parameter should be placed under e2e test component
    configuration example
e2e:
    testcafe:      - framework used for e2e test execution
      screenshot:
        enabled: true
        take-on-fail: true
        path: './tests/e2e/screenshots'
      browsers:
        - firefox --headless
    pattern:
      - /.+\.e2e\.js$/i
    ignore: ~
@avozicov
Copy link
Contributor

I would suggest an improvement here:

Actual result:

  • There is an unexpected transpile process for e2e component during npm install -g recink

Please refer to attachment for log:
screen shot 2018-02-21 at 18 44 14

Improvement suggestion:

  • all e2e component dependencies installation and transpile processes should be excluded from npm install -g recink command

@ddimitrioglo
Copy link
Contributor

@avozicov good point, thanks!

@ddimitrioglo
Copy link
Contributor

updated 😉

@avozicov
Copy link
Contributor

Test Passed

Acceptance Criteria:

  • e2e component and related processes should be excluded from npm install -g recink command
  • e2e component is required to be installed separate with the following command npm install -g recink-e2e
  • e2e component is expected to be fully functional and behave the same way as before code changes
  • basic recink functionality should work as expected and non of other components like (codeclimate, comment, snyk, terraform) should be affected and broken after code change
  • suggested improvement for transpile processes is expected to be implemented

@eistrati
Copy link
Contributor Author

eistrati commented Apr 1, 2018

Checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants