Implement ecflow option for unit testing #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
MinsukJi-NOAA
commented
Mar 18, 2020
MinsukJi-NOAA
commented
- Time taken for full unit tests is 40% of of that without using ecflow
- Numerous changes in utest for ecflow as well as better handling of baseline runs
- Modify run_test.sh to handle any failure before run_test
- Modify rt.sh to use ECFLOW_SUITE instead of regtest
- Modify rt_utils.sh to use ECFLOW_SUITE instead of regtest
- In rt_utils.sh, modify ecflow_create_run_task: make the call to run_test a foreground job so that 'set -e' error handling works properly by getting the correct exit status (another way would be to use 'job id' and 'wait job id' following the call to run_test &)
- Modify some of fv3_conf/*_run.IN files to handle errors when restart file copies fail
* Time taken for full unit tests is 40% of of that without using ecflow * Numerous changes in utest for ecflow as well as better handling of baseline runs * Modify run_test.sh to handle any failure before run_test * Modify rt.sh to use ECFLOW_SUITE instead of regtest * Modify rt_utils.sh to use ECFLOW_SUITE instead of regtest * In rt_utils.sh, modify ecflow_create_run_task: make the call to run_test a foreground job so that 'set -e' error handling works properly by getting the correct exit status (another way would be to use 'job id' and 'wait job id' following the call to run_test &) * Modify some of fv3_conf/*_run.IN files to handle errors when restart file copies fail
MinsukJi-NOAA
pushed a commit
that referenced
this pull request
Apr 22, 2021
…y#524) * point to Jun fv3atm personal fork * add CDEPS submodule * add building instructions * fix issues that came from building * builds CDEPS targets * missed w3nco dep * cleanup use of FoX and remove redundant library links in components * Add 3 files generated by genf90.pl to the CDEPS-interface/ufs directory. (#1) * remove dependency on genf90.pl for CDEPS/share * remove FoX (#2) remove FoX dependency building and use ESMF Config instead. Co-authored-by: Jun Wang <[email protected]> Co-authored-by: BinLi-NOAA <[email protected]> Co-authored-by: Brian Curtis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.