-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ASP.NET Core 3.0 Support #400
Conversation
Note that 3.x doesn't include view profiling for the moment. See dotnet/aspnetcore#11730 for progress on the 3.0 approach.
Going to give dotnet/designs#33 another shot with this.
Linux, it matters!
haaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaack
Turns out some people back in 1683 didn't agree on how to end a line and here we are. How's your day going?
Note: IsTestProject didn't work, so...trying this instead.
I dunno what this was...probably when spinning up EF6 testng.
No need to configure line endings on the client anymore, this was fixed up.
Any way we could get these changes on nuget, like before Monday EOD ? We are trying to ship Orchard Core right after dotnet 3.0, and right now we are using it on myget but we'd have to drop it as a default module if it's not on nuget. We just found out it was broken for us o. 3.0. If there is something we can do, like testing, just let us know. And it's not critical for us either, just nice to have it oob if possible. Thanks. |
@sebastienros if you can poke me as soon as 3.0 packages are available to depend on, I'll get a change and build up ASAP. We're running these preview builds already with no issues. Does the preview being on NuGet help for 3.0, ahead of stable? (if so I can do that shortly) |
The preview is fine for us, it's just about fixing the feature and it being available on nuget that matters. Thanks a lot. |
@sebastienros awesome - I just made final tweaks and tests on cleanup - |
This set of changes drops view profiling for the moment in ASP.NET Core 3.x since the types we were wrapping as "pubternal" are no longer exposed in 3.0. On the framework side, dotnet/aspnetcore#11730 is in progress so we can use the diagnostics API to hopefully re-enable this for the 3.0 release.
Samples for ASP.NET Core 2.2 and 3.0 are broken into separate samples for clarity though they are mostly the same.
Overall changes:
\n
WindowsOnly
to[Fact]
and[Theory]
for skipping inapplicable tests on Linuxxunit.runner.json
to make things work on Linux/Mono (only copied to output and in effect there)netcoreapp3.0
build forMiniProfiler.AspNet*
libs4.1.0-preview.*
to reflect the preview dependencies fornetcoreapp3.0
buildsnetcoreapp1.1
from testing (note:netstandard1.5
is still built, it's just not tested)