-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The behavior difference of 1.1 needs some experiments #955
Comments
This seems to related to a issue begin from The "Use mid-control on highres pass (second pass)" is removed since that pull request, and now if you use high-rex fix, the full ControlNet will be applied to two passes. Also, you will get two control images for each controlnet - one is for diffusion and one is for high-res fix diffusion I will add "Use mid-control on highres pass (second pass)" back today so that you can still use it. Using this option means that when you use controlnet in high-res fix, your controlnet has almostly no influence in the high-res pass (so it only control low-res pass). |
also we are not sure if this problem is related to controlnet. also i see "Steps: 10, Sampler: DPM++ 2S a Karras, CFG scale: 7.5" are you sure that your previous high quality 1.0 results are achieved with 10 steps in 480 resolution? because this parameter is not very commonly used in high quality images |
hello we added "Use only-mid-control on high-res. fix (second pass)" back. you can now use it in the setting. |
hello i tried several settings but cannot reproduce your problem. can you share input image so that we can reproduce |
I am going to close the issue given the strange paramters: 480 resolution, 10 steps. Feel free to share the input image and/or more details for reproduce. we will open this issue again if we can confirm that the problem is related to controlnet. |
Besides, I observed that the depth map generated by your cn1.0 looks like the input of your test of cn1.1 If you are using depth map and hed map extracted from your output images, then your tests for cn1.0 and cn1.1 are using different depth/hed/Canny maps. With different inputs, it is impossible to get same outputs. |
Thanks for taking a look on this! I'm surprised that you couldn't recreate the issue. I literly can recreate it everytime, with any input image and SD model. But i think i found the reason for the overblowing colors and it's the cfg scale that is now applied to cn1.1 is it possible to get this option back? or maybe we could have the option to set the cfg scale individual for each control net. |
the previous "cfg-based control" is not technically correct and it is removed in 1.1. |
let us know if you have futher questions. the issue will be closed for now |
Alright! Thanks for the clarification. The settings i wrote are exactly the same settings i used with cn1.0. from the 480 resolution to 10 steps with the Karras Sampler to the 7,5 cfg scale and it worked every time. the images i got were good, clean and precise. But i accept defeat now and have to admit that something in cn1.1 works just fundamentally different and i have to look into new settings. |
Hello @Orisen You can use the old version here Note that you need to completely remove [sd-webui-controlnet] folder before you use previous version. |
Hello @lllyasviel! Sry for bothering again but i care to much about this and i want the best for control net, because i love it! Thanks to the cn10 archive i could test my image generations again and as expected everything worked fine again and i screenshoted all the settings. For both cn10 and cn11 and maybe this time it's more clearer what is happening. Maybe it's a bug, maybe a feature, maybe a happy accident, but somehow cn10 creates better images than cn11. Maybe the Guess Mode works differently idk. Let me show you. First here the controlnet 1.0 stuff
And here the controlnet 1.1 stuff
I also tested it with a different Model and a different Input. Link to the model: https://civitai.com/models/44150/expmixline
the png info:
So, yeah there you have it. I hope this clears things up. If you know what is going on, than please let me know. Because right now cn10 feels like blackmagic and i actually would love to use cn11 to be honest. |
interesting. we will take a look soon |
Edit: The problem is related to Guess Mode. Below is results without Guess Mode Metaa (portrait:1.2) of a (woman|female:1.4) with short blonde hair|blue hair|white hair, under water, valorant style, samdoesarts, greg tocchini, jeremy mann, aleksi briclot, ellen jewett, alphonse mucha, masterpiece, best quality, highly detailed, (no lora or embed:0.0) Used EmbeddingUsed embeddings: badhandv4 [dba1], ng_deepnegative_v1_75t [1a3e] (I cannot find deformityv6) Previous ControlNet 1.0All ControlNet settings same to yours Result from 1.0 ControlNet Extension 1.1All ControlNet settings same to yours Result from 1.1 Conclusion
|
wait a minute, just find out that are all in guess mode. |
update: now we can confirm that this is related to guess mode. investigating |
God. it seems that cn1.0 has a big BUG and if you use --lowvram or --medvram, the guess mode will have an unexpected effect to make results look better. Perhaps we will have a big announcement soon. |
Hello we fixed all problems in Feel free to test and see if problems are fixed |
Now ControlNet 1.1.09's new Control Mode can reproduce the previous similar effects a (portrait:1.2) of a (woman|female:1.4) with short blonde hair|blue hair|white hair, under water, valorant style, samdoesarts, greg tocchini, jeremy mann, aleksi briclot, ellen jewett, alphonse mucha, masterpiece, best quality, highly detailed, (no lora or embed:0.0) Note that you need The result for 808080 is I do not have deformityv6 so perhaps a bit different but difference is minor |
also i do not have that upscale script you have so that mine is a bit blur |
This is result with 0.75 weight a (portrait:1.2) of a (woman|female:1.4) with short blonde hair|blue hair|white hair, under water, valorant style, samdoesarts, greg tocchini, jeremy mann, aleksi briclot, ellen jewett, alphonse mucha, masterpiece, best quality, highly detailed, (no lora or embed:0.0) |
Awesome! If you want you can test it again on your side. And here is the Upscaler: directly taken from: https://upscale.wiki/wiki/Model_Database Thanks a lot again! This is great! Very much appreciated! |
Is there an existing issue for this?
What happened?
Using one Controlnet seems to work fine, but as soon i use more than one Controlnet, the image quality get's more worse since Controlnet 1.1
After i updated to Controlnet 1.1 i tested some images done with Controlnet 1.0
On the controlnet webui page it says, it is still possible to use the old models, so i did that.
I used the preprocessors "canny", "depth_midas" and since i couldn't find the "softedge_edge" i assumed it is the "softedge_hed" preprocessor, so used this one.
Here are the controlnet 1.0 parameters from the PNG info of the img:
Here is the image quality i kinda expected. This was done with Controlnet 1.0. To be fair i didn't expected the exact same picture, but what i get now is just way worse. (see after):
And here is the image i'm getting now with Controlnet 1.1 and the exact same parameters. Way to overblown, like some values got applied doubled or trippelt:
Also strange, after i generated an image the detectmaps get displayed twice now. In Controlnet 1.0 this wasn't the case also, but to be fair i'm not sure if this means anything. But when i think of the impression that some values got applied doubled or trippelt, than maybe there is a bug somewhere where maybe 1 controlnet get's applied twice, but idk, just an idea.
I tested this now with different SD models like Protogen or RevAnimated, to make sure the SD model is not the problem.
I also tried it with Guess Mode on and off.
As soon you use more than 1 Controlnet the image quality get's worse.
Here is the full PNG info if needed:
Steps to reproduce the problem
Here are some controlnet 1.1 parameters from an image generated with Model hash: 44f90a0972, Model: protogenX34Photorealism_1:
What should have happened?
See above. Should look like the picture generated with Controlnet 1.0
Commit where the problem happens
webui: 22bcc7be
controlnet: 8d0a015
What browsers do you use to access the UI ?
Google Chrome
Command Line Arguments
No. I don't use any COMMANDLINE_ARGS
Console logs
Additional information
No response
The text was updated successfully, but these errors were encountered: