Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider converting this into a web component. #2

Open
cosmicdreams opened this issue Apr 19, 2019 · 4 comments
Open

Consider converting this into a web component. #2

cosmicdreams opened this issue Apr 19, 2019 · 4 comments

Comments

@cosmicdreams
Copy link

I'm seeing that this entire thing is written in JS / CSS and HTML. Therefore this may be a good candidate for bundling into a web component so that it can be reused in other applications easier, without having to worry about how it's implementation may be impacted by external contexts.

@backlineint
Copy link
Member

+1

Was also thinking about the possibility of abstracting some of this into a React component that could be an NPM package. Could be useful for people to make use of the captioning functionality more generically. If this was a web component, then maybe it could be used with various frameworks rather than just be a react thing (although I seem to recall that web components in React can be a bit of a can of worms - maybe that has gotten better.)

@cosmicdreams
Copy link
Author

@backlineint I've been able to figure out the WC in React thing before. It's not so bad.

@backlineint
Copy link
Member

@cosmicdreams good to know. From my perspective, this would be a fun opportunity to learn.

@cosmicdreams
Copy link
Author

Let me wrap up my Karaoke Night app and I'll share with ya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants