This repository was archived by the owner on Apr 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix microsoft#466: Fix "go to definition" and resolving imports The fix is to put user search paths in front of workspace directory so that modules inside extra paths can be used as roots for packages
If I have a folder structure like:
Will adding |
Yes, PathResolver will pick the first module, which in this case would be |
What we can do is add |
MikhailArkhipov
approved these changes
Dec 7, 2018
Unfortunately, this idea won't work because of the #468. If file is added to several roots, there will be more than one module name associated with it, which isn't supported by analyzer. |
AlexanderSher
added a commit
to AlexanderSher/python-language-server
that referenced
this pull request
Dec 22, 2018
Fix microsoft#281: Support "go to definition" for namespace packages Fix microsoft#466: Fix "go to definition" and resolving imports The fix is to put user search paths in front of workspace directory so that modules inside extra paths can be used as roots for packages
AlexanderSher
added a commit
that referenced
this pull request
Jan 9, 2019
* Clean up Completions, Find References and Hover unit tests. * Initial commit * CoreProduct buildable * Product buildable except IronPython * Move VS-specific file * add hack to prevent True/False/None/... from being use-before-def (#464) * Fix for extra paths inside workspace (#467) Fix #281: Support "go to definition" for namespace packages Fix #466: Fix "go to definition" and resolving imports The fix is to put user search paths in front of workspace directory so that modules inside extra paths can be used as roots for packages * Last port * - Add nuspec - Fix #501: PTVS-LS Integration: Fix LS hanging during file changes - Fix #502: PTVS-LS Integration: Add required *.py files to the vsix * Address CR comments
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
Fix microsoft#281: Support "go to definition" for namespace packages Fix microsoft#466: Fix "go to definition" and resolving imports The fix is to put user search paths in front of workspace directory so that modules inside extra paths can be used as roots for packages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #281: Support "go to definition" for namespace packages
Fix #466: Fix "go to definition" and resolving imports
The fix is to put user search paths in front of workspace directory so that modules inside extra paths can be used as roots for packages