-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@types import considered valid #15540
Labels
Milestone
Comments
@aozgaa I will be submitting a PR for this today |
nowy
added a commit
to nowy/TypeScript
that referenced
this issue
May 15, 2017
Fix issue: microsoft#15540 - Modify checker; external imports to account for imported modules containing '@types/'. - Add diagnostic message. - Add test case
nowy
added a commit
to nowy/TypeScript
that referenced
this issue
May 15, 2017
Fix issue: microsoft#15540 - Modify checker; external imports to account for imported modules containing '@types/'. - Add diagnostic message. - Add test case
nowy
added a commit
to nowy/TypeScript
that referenced
this issue
May 15, 2017
Fix issue: microsoft#15540 - Modify checker; external imports to account for imported modules containing '@types/'. - Add diagnostic message. - Add test case
nowy
added a commit
to nowy/TypeScript
that referenced
this issue
May 15, 2017
Fix issue: microsoft#15540 - Modify checker; external imports to account for imported modules containing '@types/'. - Add diagnostic message. - Add test case
nowy
added a commit
to nowy/TypeScript
that referenced
this issue
May 15, 2017
Fix issue: microsoft#15540 - Modify checker; external imports to account for imported modules containing '@types/'. - Add diagnostic message. - Add test case
mhegazy
pushed a commit
that referenced
this issue
May 19, 2017
* Fix #15540: Throw error when importing @types Fix issue: #15540 - Modify checker; external imports to account for imported modules containing '@types/'. - Add diagnostic message. - Add test case * FIX-15540: Review changes - Replace `substr` with `startsWith` - move diagnostics message to more relevant place - Add `removePrefix` helper function
thanks @nowy! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
TypeScript Version: 2.2.1 / nightly (2.2.0-dev.201xxxxx)
Code
Expected behavior:
Error on import in
app.ts
. Perhaps with a suggestion/quickfix to remove the@types/
prefix?Actual behavior:
No error on import.
The text was updated successfully, but these errors were encountered: