Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Quantum Fourier Transform (QFT) Kata #88

Merged
merged 34 commits into from
Apr 28, 2020
Merged

Conversation

leo-du
Copy link
Contributor

@leo-du leo-du commented Mar 22, 2019

QFT kata, including basic QFT, approximate QFT, QFT addition and multiplication, Shor's Discrete Logarithm algorithm.

Co-authored-by: Liangyu [email protected]

@msftclas
Copy link

msftclas commented Mar 22, 2019

CLA assistant check
All CLA requirements met.

@tcNickolas tcNickolas requested a review from martinquantum April 5, 2019 17:35
* Update to QDK 0.11
* Trim the parts of the kata beyond the QFT implementation
* Add more detailed steps to QFT implementation
Copy link
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, I apologize for taking so long to get back to you! QFT is not a simple topic to teach, and I kept returning to it trying to figure out a way to split up the tasks in your PR into smaller steps - I don't think the task "implement QFT" is small enough to help the learner internalize the implementation. Finally a couple of weeks ago I realized how to break down the algorithm in N&C into digestible pieces, but at that point it would be rude to ask you to do those changes (it has been a year...), so I went in and implemented those intermediate tasks myself, together with a project update to the latest QDK version.

For the applications of QFT, each of them deserves a separate kata, since each of them is too big to implement in just one or two steps, they all need a lot of smaller tasks to make them palatable. So I removed them and will add them to the future roadmap.

On the other hand, I think this kata needs 2nd part covering simpler QFT applications, such as figuring out the period of a signal or preparing periodic signals. I'll continue working on this outside of this PR, since it's a completely new direction for this kata.

Thank you for your work!

@tcNickolas tcNickolas merged commit d5da35d into microsoft:master Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants