Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-tune selection of cities #5

Closed
ruestefa opened this issue Dec 3, 2020 · 2 comments
Closed

Fine-tune selection of cities #5

ruestefa opened this issue Dec 3, 2020 · 2 comments

Comments

@ruestefa
Copy link
Contributor

ruestefa commented Dec 3, 2020

Currently (v0.13.11), the city labels are selected as follows:

  • All captital cities.
  • All additional cities of a certain size, which depends on whether the domain is considered continental-, regional- or country-scale.

This works OK for Europe. However, the size thresholds are not appropriate for other regions like SE Asia with many huge cities or Siberia with barely any cities. Also, sometimes two cities in close vicinity of similar will both be shown when one would (visually) suffice.

TODO: Fine-tune the selection of cities.

Possibilities:

  • Define the size thresholds based not only on the scale, but also on the region as identified by the release point.
  • Hardcode some cities, either including or exluding them.
@ruestefa
Copy link
Contributor Author

Added list excluded_cities to pyflexplot.plotting.map_axes::MapAxes::_ax_add_cities::is_of_interest to exclude the city Incheon. Add additional cities if necessary.

@ruestefa
Copy link
Contributor Author

Note: Instead of hardcoding the cities, the list of excluded cities would better be added to MapAxesConfig and defined in pyflexplot.plots, where all the other stuff is defined. This would also make it easy to exclude cities based on the model, domain etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant