From fd5818a00e99f020ec07761c20e59897ce238bc7 Mon Sep 17 00:00:00 2001 From: JhonnyV-V Date: Fri, 3 May 2024 14:47:29 -0400 Subject: [PATCH 1/5] adding edge-chromium support for createExternalExtensionProvider --- CHANGELOG.md | 6 ++++++ package.json | 2 +- .../createExternalExtensionProvider.ts | 17 +++++++++++++++-- .../external-extension-config.json | 5 +++++ 4 files changed, 27 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 922e9454..6ceb68e6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [16.1.1] + +### Fixed + +- Added support for edge-chromium for ([createExternalExtensionProvider](https://github.com/MetaMask/providers/blob/main/src/extension-provider/createExternalExtensionProvider.ts)) + ## [16.1.0] ### Added diff --git a/package.json b/package.json index 36e213ff..42e45cc8 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@metamask/providers", - "version": "16.1.0", + "version": "16.1.1", "description": "A JavaScript Ethereum provider that connects to the wallet over a stream", "keywords": [ "MetaMask", diff --git a/src/extension-provider/createExternalExtensionProvider.ts b/src/extension-provider/createExternalExtensionProvider.ts index 88d2c9b7..27ec4d49 100644 --- a/src/extension-provider/createExternalExtensionProvider.ts +++ b/src/extension-provider/createExternalExtensionProvider.ts @@ -53,7 +53,20 @@ export function createExternalExtensionProvider( * @returns The extension ID. */ function getExtensionId(typeOrId: ExtensionType) { - const ids = - browser?.name === 'firefox' ? config.firefoxIds : config.chromeIds; + let ids: { + stable: string; + beta: string; + flask: string; + }; + switch (browser?.name) { + case 'edge-chromium': + ids = config.edgeChromiumIds; + break; + case 'firefox': + ids = config.firefoxIds; + break; + default: + ids = config.chromeIds; + } return ids[typeOrId as keyof typeof ids] ?? typeOrId; } diff --git a/src/extension-provider/external-extension-config.json b/src/extension-provider/external-extension-config.json index c780400b..875c9b85 100644 --- a/src/extension-provider/external-extension-config.json +++ b/src/extension-provider/external-extension-config.json @@ -4,6 +4,11 @@ "beta": "pbbkamfgmaedccnfkmjcofcecjhfgldn", "flask": "ljfoeinjpaedjfecbmggjgodbgkmjkjk" }, + "edgeChromiumIds": { + "stable": "ejbalbakoplchlghecdalmeeeajnimhm", + "beta": "pbbkamfgmaedccnfkmjcofcecjhfgldn", + "flask": "ljfoeinjpaedjfecbmggjgodbgkmjkjk" + }, "firefoxIds": { "stable": "webextension@metamask.io", "beta": "webextension-beta@metamask.io", From 75ed3cd6dcef2c3e6c3ed485102d270c0f73f9f5 Mon Sep 17 00:00:00 2001 From: Jhonny Varela Date: Thu, 16 May 2024 08:56:31 -0400 Subject: [PATCH 2/5] Update package.json version Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 42e45cc8..36e213ff 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@metamask/providers", - "version": "16.1.1", + "version": "16.1.0", "description": "A JavaScript Ethereum provider that connects to the wallet over a stream", "keywords": [ "MetaMask", From 9e41f9e897a3b5c93f6328750fdedec3c29a08e0 Mon Sep 17 00:00:00 2001 From: Jhonny Varela Date: Thu, 16 May 2024 08:56:41 -0400 Subject: [PATCH 3/5] Update CHANGELOG.md Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> --- CHANGELOG.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ceb68e6..9113e737 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,8 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] -## [16.1.1] - ### Fixed - Added support for edge-chromium for ([createExternalExtensionProvider](https://github.com/MetaMask/providers/blob/main/src/extension-provider/createExternalExtensionProvider.ts)) From ee84e4a43030f08a66d38e880292e83c9992fd50 Mon Sep 17 00:00:00 2001 From: Jhonny Varela Date: Thu, 27 Jun 2024 15:45:43 -0400 Subject: [PATCH 4/5] Update CHANGELOG.md Change link to file to link to pr Co-authored-by: Elliot Winkler --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9113e737..cb464198 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed -- Added support for edge-chromium for ([createExternalExtensionProvider](https://github.com/MetaMask/providers/blob/main/src/extension-provider/createExternalExtensionProvider.ts)) +- Added support for edge-chromium to `createExternalExtensionProvider` ([#318](https://github.com/MetaMask/providers/pull/318)) ## [16.1.0] From 6e3a5a17b4efbd29c875fbb80c9a9da0b822d2b9 Mon Sep 17 00:00:00 2001 From: legobt <6wbvkn0j@anonaddy.me> Date: Mon, 23 Sep 2024 22:39:36 +0000 Subject: [PATCH 5/5] chore: update test coverage thresholds --- jest.config.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jest.config.js b/jest.config.js index ff28c22d..b43953d4 100644 --- a/jest.config.js +++ b/jest.config.js @@ -45,10 +45,10 @@ const baseConfig = { // An object that configures minimum threshold enforcement for coverage results coverageThreshold: { global: { - branches: 64.95, + branches: 64.65, functions: 65.65, - lines: 66.04, - statements: 66.13, + lines: 65.51, + statements: 65.61, }, },