Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation warnings can appear clipped below the scrollable area #9136

Closed
danfinlay opened this issue Aug 4, 2020 · 1 comment · Fixed by #9228
Closed

Confirmation warnings can appear clipped below the scrollable area #9136

danfinlay opened this issue Aug 4, 2020 · 1 comment · Fixed by #9228
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug

Comments

@danfinlay
Copy link
Contributor

On the transaction confirmation screen, we have an area where we render warnings, like "This transaction will likely run out of gas".

That area is currently at the bottom of the TX details view, which is scrollable, and prioritizes the "Confirmation" button, which is fixed at the bottom of the view.

This means relevant information can be missed by the user who does not scroll, while the confirm button remains prominent.

Possible mitigations (some can combine):

  • Add the confirm/cancel buttons to the scrollable region, so they cannot be clicked until all details have been seen.
  • Move the warning message to the top of the confirmation view
  • Disable the Confirm button until scrolling to the bottom, in the style of common terms & conditions views (maybe a "dark pattern", as it may encourage not reading closely).

@rachelcope

@Gudahtt Gudahtt added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Aug 4, 2020
@rachelcope
Copy link

rachelcope commented Aug 11, 2020

I am in favor of @danfinlay 's option 1 - adding the confirm/cancel buttons to the scrollable area.

The warning message showing up below the fold happens only (I believe) when user has advanced gas options turned on.

Transaction confirmation with advanced gas options on Screen Shot 2020-08-11 at 11 24 41 AM

If the user sees the default transaction confirmation, then there is room above the fold for the error to appear and should not require the user to scroll to confirm.

Transaction confirmation default Screen Shot 2020-08-11 at 11 26 29 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants