Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom nonce doesn't work for value 0 #8882

Closed
aminlatifi opened this issue Jul 2, 2020 · 2 comments · Fixed by #8883
Closed

Custom nonce doesn't work for value 0 #8882

aminlatifi opened this issue Jul 2, 2020 · 2 comments · Fixed by #8883

Comments

@aminlatifi
Copy link

Describe the bug
Custom nonce feature doesn't work for the first transaction of account (nonce zero)

To Reproduce (REQUIRED)
Steps to reproduce the behavior

  1. Try to use a new account which hasn't any transaction on network, so it's first transaction will have nonce value zero.
  2. Connect metamask to mainnet or any testnet which doesn't do transaction immediately
  3. Do a transaction in network and set low gas limit for it in order to have enough time for next transactions
  4. Cancel the first transaction (this step may not be required, but I needed for my test)
  5. Create another transaction with high gas value and set its nonce value manually to zero

Expected behavior
The second transaction should be mined by network and the first one should be failed! But metamask doesn't care about the custom nonce zero and eventually both transactions will be mined. First transaction will have nonce value 0 and the second one will have nonce 1

Screenshots
image

Browser details (please complete the following information):

  • OS: macOS Catalina
  • Browser Chrome Version 83.0.4103.116 (Official Build) (64-bit)
  • MetaMask Version 7.7.9
@tmashuang
Copy link
Contributor

tmashuang commented Jul 2, 2020

This has been addressed in #8618, will be fixed in the next version.

@tmashuang
Copy link
Contributor

Actually, upon looking at this a little more, setting the nonce to 0 doesn't seem to work. Will update more with my findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants