Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Retry" option for failed transactions #7193

Closed
dpazdan opened this issue Sep 19, 2019 · 4 comments
Closed

Add "Retry" option for failed transactions #7193

dpazdan opened this issue Sep 19, 2019 · 4 comments
Assignees
Labels
area-UI Relating to the user interface. type-enhancement

Comments

@dpazdan
Copy link

dpazdan commented Sep 19, 2019

What problem are you trying to solve?
Sometimes a user might want or need to retry a failed transaction. For example, if a speed up, or cancel attempt fails with gas too low, then the original transaction will continue to hold up future transactions for a long time. Also if the transaction fails due to a network connection issue.

Describe the solution you'd like
On a failed transaction, in the activity area of MetaMask, allow the user to select "Retry". This would open a screen with editable gas options, same to address, and same nonce.

Additional context
image

@danjm danjm added area-UI Relating to the user interface. reserved type-enhancement labels Oct 16, 2019
@danjm
Copy link
Contributor

danjm commented Oct 21, 2019

ping @rickycodes

@danjm
Copy link
Contributor

danjm commented Oct 21, 2019

Notes:

  • place retry button next to speedUp, copy-to-clipboard and viewOnEtherscan buttons in ui/app/components/app/transaction-list-item-details/transaction-list-item-details.component.js
  • clicking it should create a new transaction with the exact same txParams as the failed transaction (it should appear in the tx-history list)
  • To consistently reproduce:
    • select "Main Ethereum Network" as your network
    • send a transaction with a gas price set to 0.00001
    • transaction will fail

@brad-decker
Copy link
Contributor

@dpazdan we can now retry transactions from the details view -- not sure if that was the case at the time this issue was created. @rickycodes / @danjm do we need this to be in the failed transaction list item to be solved?

@Gudahtt
Copy link
Member

Gudahtt commented Oct 7, 2020

I think we can close this; it was fixed in #7296

@Gudahtt Gudahtt closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. type-enhancement
Projects
None yet
Development

No branches or pull requests

6 participants