Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable privacy mode by default #6352

Closed
2 of 7 tasks
bdresser opened this issue Mar 26, 2019 · 4 comments · Fixed by #6904
Closed
2 of 7 tasks

Enable privacy mode by default #6352

bdresser opened this issue Mar 26, 2019 · 4 comments · Fixed by #6904

Comments

@bdresser
Copy link
Contributor

bdresser commented Mar 26, 2019

Privacy mode should be "ON" by default, with the option to disable.

This requires

  • UI to notify users this change was made
  • addition of "force log in" button described in Allow manual enable for legacy sites. #6320, Add way to bypass privacy mode on a per-site basis #6110
  • some affordance to help users on legacy sites know that they must force log-in
    • research if we can detect sites trying to read .accounts[0] before requesting access
    • if yes, we can show a conditional UI helper just when necessary
    • if no, we should show something persistent for a period of time
  • message from Twitter and Medium
@bdresser
Copy link
Contributor Author

cc @bitpshr @whymarrh @JSON-LEE13

@omnat
Copy link

omnat commented Mar 26, 2019

Note:
conditional UI helper can be a notification / pop-up that leads user directly to the force log-in option. cc @cjeria

@whymarrh
Copy link
Contributor

  • some affordance to help users on legacy sites know that they must force log-in
    • research if we can detect sites trying to read .accounts[0] before requesting access

Refs #6384 (comment) and #6384 (comment)

The answer is yes, we can detect (pending some implementation details) sites that aren't using the 1102 flow.

@bdresser
Copy link
Contributor Author

bdresser commented May 9, 2019

design issue: MetaMask/Design#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@bdresser @whymarrh @danjm @omnat and others