fix: exclude smart transaction status page from rate limiting

[httpJunkie]

This change adds smartTransaction:showSmartTransactionStatusPage to the typesExcludedFromRateLimiting array when initializing the ApprovalController.

This prevents the "Request of type 'smartTransaction:showSmartTransactionStatusPage' already pending" error that was occurring when users executed sequential transactions in quick succession.

Description

Before the fix, MetaMask's ApprovalController was rate-limiting sequential smartTransaction:showSmartTransactionStatusPage requests, causing errors when users attempted multiple transactions.

What is being Rate Limited by the typesExcludedFromRateLimiting?

The rate limiting is happening on API request types within MetaMask's internal architecture. Specifically: When a user initiates a transaction ie: eth_sendTransaction, MetaMask makes an internal request of type smartTransaction:showSmartTransactionStatusPage.

A "request type" in this context refers to a specific category of internal API calls within MetaMask's architecture. Each request type is a string identifier (like smartTransaction:showSmartTransactionStatusPage) that represents an operation that extension needs to perform. The ApprovalController tracks these "request types" to manage permissions, prevent spam, and handle confirmations from users.

The ApprovalController component in MetaMask was designed to prevent many identical "request types" from the same source in a short time period, ie: "rate limiting".

This means that when a user tried to make multiple transactions quickly (simulated by the test dapp included below), they could see the status page for the first transaction, but subsequent status pages were being BLOCKED by this rate-limiting mechanism.

Our fix tells the ApprovalController to exclude this particular request type from its rate limiting checks, so that multiple transaction status pages can be displayed in sequence without error.

Related issues

Fixes: #30387

Manual testing steps

Repro Setup:

1. Run the following command to clone and run the test dapp that reproduces this error:

git clone https://github.com/httpJunkie/metamask-sequential-tx-repro.git &&
cd metamask-sequential-tx-repro && yarn && yarn dev

2. Cmd+Click on the localhost URL in terminal to run the dapp

Manually Test the Extension:

1. Load a version 12.13.0 or earlier version of MetaMask
2. Connect to Ethereum Mainnet (testnet seems harder to repro this bug)
3. Navigate to the test dapp
4. Connect your MetaMask wallet to the dapp
5. Click the "Send 3 Sequential Transactions" button
6. Approve transactions as prompted by MetaMask
7. Verify console errors containing

Request of type 'smartTransaction:showSmartTransactionStatusPage' already pending

8. Install the updated MetaMask extension build containing the fix
9. Connect to Ethereum Mainnet
10. Navigate to the test dapp
11. Connect your MetaMask wallet to the dapp
12. Click the "Send 3 Sequential Transactions" button
13. Approve each transaction when prompted by MetaMask
14. Verify no console errors containing

Request of type 'smartTransaction:showSmartTransactionStatusPage' already pending

15. Confirm that each transaction is processed correctly
16. Verify that the status page for each transaction is displayed properly
17. Ensure all three transactions complete successfully

Expected Results

• All transactions should execute without errors
• Each transaction should display its status page
• No errors should appear in the console

Screenshots/Recordings

Before

before-seq-tx.mov

After

after-seq-tx.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [8a9a42a]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1726 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	367	1946	1643	314	151
		domContentLoaded	1477	1917	1689	121	58
		load	1531	1990	1726	126	61
		domInteractive	26	93	43	20	9
		backgroundConnect	12	87	41	23	11
		firstReactRender	15	75	40	22	11
		getState	6	81	24	23	11
		initialActions	0	1	0	0	0
		loadScripts	1095	1433	1244	98	47
		setupStore	7	65	13	12	6
		uiStartup	1738	2208	1975	154	74

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 50 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[httpJunkie]

I have read the CLA Document and I hereby sign the CLA

[metamaskbot]

Builds ready [646d34e]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1645 ± 60 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1450	1867	1645	123	59
		domContentLoaded	1443	1832	1619	117	56
		load	1451	1869	1645	124	60
		domInteractive	25	67	34	11	5
		backgroundConnect	8	77	32	22	10
		firstReactRender	14	78	28	21	10
		getState	4	51	11	11	5
		initialActions	0	1	0	0	0
		loadScripts	1052	1355	1198	94	45
		setupStore	7	65	18	19	9
		uiStartup	1679	2154	1875	144	69

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 50 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)