Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(30509): remove 'fake-metrics-id' in e2e to avoid controller error #30515

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Feb 21, 2025

Description

A variety of E2E tests now have console errors in the service worker process related to failures fetching remote feature flags. The error is caused by an invalid mock metametrics ID (fake-metrics-id). Since we introduced validation in @metamas/remote-feature-flags controller: https://github.com/MetaMask/core/blob/main/packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.ts#L52, we need to modify the existing e2e test how metametricsId is mocked into a valid hex value.

Open in GitHub Codespaces

Related issues

Fixes: #30509

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica self-assigned this Feb 21, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 21, 2025
@DDDDDanica DDDDDanica force-pushed the fix/30509-e2e-metrics-id branch 3 times, most recently from 65b42f0 to a488fc9 Compare February 24, 2025 07:30
@DDDDDanica DDDDDanica force-pushed the fix/30509-e2e-metrics-id branch from a488fc9 to 889d57e Compare February 24, 2025 08:19
@metamaskbot
Copy link
Collaborator

Builds ready [889d57e]
Page Load Metrics (1538 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1390177315369144
domContentLoaded1379175215028742
load1389177315388641
domInteractive239240188
backgroundConnect126536178
firstReactRender1376282311
getState45911157
initialActions00000
loadScripts1004130510997636
setupStore771232412
uiStartup15532047175410651
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica DDDDDanica marked this pull request as ready for review February 24, 2025 13:46
@DDDDDanica DDDDDanica requested a review from a team as a code owner February 24, 2025 13:46
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snaps changes LGTM

@DDDDDanica DDDDDanica added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-extension-platform Extension Platform team
Projects
Status: Review finalised - Ready to be merged
Development

Successfully merging this pull request may close these issues.

[Bug]: E2E test Console errors related to fetching remote feature flags
4 participants