fix(30509): remove 'fake-metrics-id' in e2e to avoid controller error #30515
+100
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A variety of E2E tests now have console errors in the service worker process related to failures fetching remote feature flags. The error is caused by an invalid mock metametrics ID (
fake-metrics-id
). Since we introduced validation in @metamas/remote-feature-flags controller: https://github.com/MetaMask/core/blob/main/packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.ts#L52, we need to modify the existing e2e test howmetametricsId
is mocked into a valid hex value.Related issues
Fixes: #30509
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist