Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: firefox-bundle-script #30476

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Feb 20, 2025

Description

Open in GitHub Codespaces

Firefox submissions require the firefox reviewers to reproduce our builds. We need to make this as easy as possible for them. This PR introduces the bundle.sh script that will be updated with the environment variables from CircleCI and posted to a private repo when a release is published.

Related issues

Fixes: https://github.com/MetaMask/metamask-planning/issues/4207

Manual testing steps

  1. Make a fake release and watch https://github.com/MetaMask/firefox-bundle-script getting updated with the correct values.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Feb 20, 2025
@itsyoboieltr itsyoboieltr requested a review from a team as a code owner February 20, 2025 20:15
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 20, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [32d78a3]
Page Load Metrics (1696 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14392173169319594
domContentLoaded14302096166218589
load14482179169619392
domInteractive1988432010
backgroundConnect1084372311
firstReactRender1476362412
getState55111105
initialActions00000
loadScripts9961590121515273
setupStore864192010
uiStartup164224731939229110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [283eefb]
Page Load Metrics (1638 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14551852164111756
domContentLoaded14441795161210551
load14531850163811555
domInteractive25126412512
backgroundConnect1184302211
firstReactRender1473322412
getState55916189
initialActions01000
loadScripts10191383118910048
setupStore76317188
uiStartup16582087187211555
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants