ci: enable circular dep linting #30148

davidmurdoch · 2025-02-06T01:26:49Z

This PR prevents circular dependencies from being added to our codebase.

Description

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-06T01:27:02Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-06T02:00:57Z

Builds ready [d9391f4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1687 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1495	2141	1681	149	71
		domContentLoaded	1449	2124	1656	150	72
		load	1497	2145	1687	153	73
		domInteractive	23	66	30	9	4
		backgroundConnect	10	79	34	25	12
		firstReactRender	16	74	38	24	11
		getState	5	48	11	9	4
		initialActions	0	1	0	0	0
		loadScripts	1059	1659	1205	131	63
		setupStore	7	64	19	20	10
		uiStartup	1700	2380	1914	167	80

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

socket-security · 2025-02-13T21:45:36Z

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@types/[email protected]	None	`0`	6.57 kB	types
npm/@types/[email protected]	None	`0`	25.1 kB	types
npm/[email protected] 🔁 npm/[email protected]	None	`0`	44.6 kB	jonschlinkert
npm/[email protected] 🔁 npm/[email protected]	None	`0`	16.7 kB	jonschlinkert
npm/[email protected] 🔁 npm/[email protected]	None	`0`	56.6 kB	doowb

View full report↗︎

metamaskbot · 2025-02-18T00:10:10Z

Builds ready [8e2731e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1641 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1520	1968	1649	127	61
		domContentLoaded	1478	1947	1614	128	62
		load	1509	1973	1641	133	64
		domInteractive	21	99	39	24	11
		backgroundConnect	8	67	32	23	11
		firstReactRender	14	70	35	24	11
		getState	4	36	10	7	4
		initialActions	0	1	0	0	0
		loadScripts	986	1455	1165	109	53
		setupStore	7	68	16	18	8
		uiStartup	1690	2270	1856	141	68

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-18T18:42:26Z

Builds ready [7ddc5bf]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1558 ± 60 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1410	1947	1562	129	62
		domContentLoaded	1396	1753	1520	82	39
		load	1411	1945	1558	125	60
		domInteractive	22	68	33	14	7
		backgroundConnect	9	468	41	99	48
		firstReactRender	14	100	40	26	12
		getState	4	51	13	15	7
		initialActions	0	1	0	0	0
		loadScripts	982	1348	1095	81	39
		setupStore	7	74	25	26	12
		uiStartup	1612	2285	1809	177	85

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

davidmurdoch · 2025-02-18T23:59:49Z

@metamaskbot update-policies

metamaskbot · 2025-02-19T00:12:58Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-02-19T00:47:37Z

Builds ready [194c797]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1744 ± 130 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	461	2618	1650	356	171
		domContentLoaded	1470	2504	1721	266	128
		load	1480	2519	1744	271	130
		domInteractive	24	138	41	28	14
		backgroundConnect	10	70	25	18	9
		firstReactRender	14	88	37	26	13
		getState	5	90	15	21	10
		initialActions	0	1	0	0	0
		loadScripts	1049	1912	1254	217	104
		setupStore	7	90	25	25	12
		uiStartup	1733	2910	2004	303	146

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-20T00:14:08Z

Builds ready [a58a5c6]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1609 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	337	1738	1523	289	139
		domContentLoaded	1367	2156	1570	158	76
		load	1390	2192	1609	162	78
		domInteractive	23	78	32	14	7
		backgroundConnect	9	148	43	32	16
		firstReactRender	13	63	21	12	6
		getState	4	59	18	17	8
		initialActions	0	0	0	0	0
		loadScripts	961	1600	1134	128	61
		setupStore	7	57	23	20	10
		uiStartup	1595	2525	1830	200	96

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-24T23:09:32Z

Builds ready [45b07bd]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1647 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	489	1948	1555	279	134
		domContentLoaded	1424	2207	1621	190	91
		load	1429	2224	1647	189	91
		domInteractive	24	186	49	39	19
		backgroundConnect	10	73	31	16	8
		firstReactRender	14	72	33	22	11
		getState	5	65	25	22	11
		initialActions	0	1	0	0	0
		loadScripts	1013	1779	1201	175	84
		setupStore	7	57	15	14	7
		uiStartup	1652	2390	1876	202	97

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot added the team-extension-platform Extension Platform team label Feb 6, 2025

davidmurdoch added 2 commits February 13, 2025 15:37

ci: enable circular dep linting

a304a0a

run via madge instead

077da6a

davidmurdoch force-pushed the enable-circular-dep-lint branch from d9391f4 to 077da6a Compare February 13, 2025 21:43

davidmurdoch added 3 commits February 14, 2025 13:07

Merge branch 'main' into enable-circular-dep-lint

48640fd

add failIfDisallowedCircularDepsFound check

d13a037

lava

8e2731e

gauthierpetetin assigned davidmurdoch Feb 18, 2025

davidmurdoch added 2 commits February 18, 2025 12:23

Merge branch 'main' into enable-circular-dep-lint

2ddbf49

lint

7ddc5bf

davidmurdoch added 2 commits February 18, 2025 14:08

yarn dedupe

59d6f92

Merge branch 'main' into enable-circular-dep-lint

13caec9

Update LavaMoat policies

194c797

davidmurdoch added 2 commits February 19, 2025 18:37

Merge branch 'main' into enable-circular-dep-lint

bd5b2ab

don't allow any at all

a58a5c6

davidmurdoch added 6 commits February 20, 2025 16:49

Merge branch 'main' into enable-circular-dep-lint

5e944d2

wip

2b0e560

lint

b3591cd

hm

132f6f5

clean up

d4aa71c

lint

0add605

davidmurdoch added 4 commits February 24, 2025 16:47

Merge branch 'main' into enable-circular-dep-lint

13d8208

update missing deps

f2f26e3

fixes

29a5da5

revert after some tests

45b07bd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: enable circular dep linting #30148

ci: enable circular dep linting #30148

davidmurdoch commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025

metamaskbot commented Feb 6, 2025

socket-security bot commented Feb 13, 2025 •

edited

Loading

metamaskbot commented Feb 18, 2025

metamaskbot commented Feb 18, 2025

davidmurdoch commented Feb 18, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 20, 2025

metamaskbot commented Feb 24, 2025

ci: enable circular dep linting #30148

Are you sure you want to change the base?

ci: enable circular dep linting #30148

Conversation

davidmurdoch commented Feb 6, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 6, 2025

metamaskbot commented Feb 6, 2025

socket-security bot commented Feb 13, 2025 • edited Loading

metamaskbot commented Feb 18, 2025

metamaskbot commented Feb 18, 2025

davidmurdoch commented Feb 18, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 20, 2025

metamaskbot commented Feb 24, 2025

davidmurdoch commented Feb 6, 2025 •

edited

Loading

socket-security bot commented Feb 13, 2025 •

edited

Loading