Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix security settings layout #29258

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Dec 16, 2024

Description

This PR improves the layout of the basic security section by aligning the toggle button with the heading text. The changes include:

  1. Restructuring the layout using Box components with proper alignment
  2. Moving the toggle button to be inline with the heading
  3. Improving the visual hierarchy by using proper Typography components
  4. Maintaining the description text below with appropriate spacing

Open in GitHub Codespaces

Related issues

Fixes: #26667

Manual testing steps

  1. Go to Settings > Security & Privacy
  2. Observe the Basic Configuration section at the top
  3. Verify the toggle button is properly aligned with the heading
  4. Verify the description text appears below with proper spacing

Screenshots/Recordings

Before

before720.mov

After

security.settings.after720.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Extension label Dec 16, 2024
@georgewrmarshall georgewrmarshall self-assigned this Dec 16, 2024
@georgewrmarshall georgewrmarshall marked this pull request as ready for review December 16, 2024 23:01
@metamaskbot
Copy link
Collaborator

Builds ready [71f1188]
Page Load Metrics (1571 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34520291512306147
domContentLoaded14071946155613866
load14151975157113866
domInteractive22113452512
backgroundConnect65622147
firstReactRender15102292512
getState478172311
initialActions01000
loadScripts10541456115311957
setupStore65315178
uiStartup15902236179717483
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 177 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica
Copy link
Contributor

LGTM !

DDDDDanica
DDDDDanica previously approved these changes Dec 16, 2024
NidhiKJha
NidhiKJha previously approved these changes Dec 17, 2024
@DDDDDanica DDDDDanica enabled auto-merge December 17, 2024 16:40
@metamaskbot
Copy link
Collaborator

Builds ready [48743dc]
Page Load Metrics (1733 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25720471591420202
domContentLoaded15492006170313866
load15582047173314670
domInteractive21108442311
backgroundConnect981302412
firstReactRender1599443115
getState589212512
initialActions00000
loadScripts11271520124810952
setupStore686212613
uiStartup171727362098247118
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 177 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica DDDDDanica added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 22bcc76 Dec 18, 2024
77 checks passed
@DDDDDanica DDDDDanica deleted the fix/26667/toggle-alignment branch December 18, 2024 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Update toggles in Security and Privacy Settings to be inline with title
5 participants