-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix security settings layout #29258
Merged
Merged
+100
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [71f1188]
Page Load Metrics (1571 ± 66 ms)
Bundle size diffs
|
LGTM ! |
DDDDDanica
previously approved these changes
Dec 16, 2024
NidhiKJha
previously approved these changes
Dec 17, 2024
48743dc
71f1188
to
48743dc
Compare
Builds ready [48743dc]
Page Load Metrics (1733 ± 70 ms)
Bundle size diffs
|
DDDDDanica
approved these changes
Dec 17, 2024
brianacnguyen
approved these changes
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.11.0
Issue or pull request that will be included in release 12.11.0
team-design-system
All issues relating to design system in Extension
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the layout of the basic security section by aligning the toggle button with the heading text. The changes include:
Related issues
Fixes: #26667
Manual testing steps
Screenshots/Recordings
Before
before720.mov
After
security.settings.after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist