From efec22f0b59030523f6fd36827dc698f80e0e40f Mon Sep 17 00:00:00 2001 From: Elliot Winkler Date: Fri, 1 Dec 2023 14:27:37 -0700 Subject: [PATCH] Bump min Node to 16, and use LTS Node for dev (#332) **This change is breaking.** We could bump this monorepo to Node 18, but since these packages are heavily depended upon, we don't need to do that yet until we've confirmed all other projects are using 18. Using the LTS version of Node puts us on a more modern version for development (and also happens to fix the `.nvmrc` file so `asdf` can read it). Also fix the CI matrix so it matches the versions we actually support. --------- Co-authored-by: legobt <6wbvkn0j@anonaddy.me> --- .github/workflows/lint-test.yml | 4 ++-- .nvmrc | 2 +- README.md | 4 ++-- package.json | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/lint-test.yml b/.github/workflows/lint-test.yml index ed9a94c0..ffac91ac 100644 --- a/.github/workflows/lint-test.yml +++ b/.github/workflows/lint-test.yml @@ -26,7 +26,7 @@ jobs: - prepare strategy: matrix: - node-version: [14.x, 16.x, 18.x, 19.x] + node-version: [16.x, 18.x, 20.x] steps: - uses: actions/checkout@v3 - name: Use Node.js ${{ matrix.node-version }} @@ -57,7 +57,7 @@ jobs: - prepare strategy: matrix: - node-version: [14.x, 16.x, 18.x, 19.x] + node-version: [16.x, 18.x, 20.x] steps: - uses: actions/checkout@v3 - name: Use Node.js ${{ matrix.node-version }} diff --git a/.nvmrc b/.nvmrc index 958b5a36..b009dfb9 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v14 +lts/* diff --git a/README.md b/README.md index 80f5db53..a8e0a1c7 100644 --- a/README.md +++ b/README.md @@ -8,8 +8,8 @@ correctly specify their peer dependencies. ### Setup -- Install [Node.js](https://nodejs.org) version 14 - - If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm use` will automatically choose the right node version for you. +- Install the current LTS version of [Node.js](https://nodejs.org) + - If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm install` will install the latest version and running `nvm use` will automatically choose the right node version for you. - Install [Yarn v3](https://yarnpkg.com/getting-started/install) - Run `yarn install` to install dependencies and run any required post-install scripts diff --git a/package.json b/package.json index f23f41be..79c9e2df 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ }, "packageManager": "yarn@3.2.4", "engines": { - "node": ">=14.0.0" + "node": "^16.20 || ^18.18 || >=20" }, "lavamoat": { "allowScripts": {