Contained subroutines ignored, and another program with same name is added as dependency

[hiker]

A recent update to LFRic caused more of socrates files to be included in the build. One thing we noticed:
socrates/interface_core/socrates_bones.f90 contains a subroutine socrates_bones, which contains (as in the Fortran statement) a subroutine scale_field.

The analysis results in:

{
    "fpath": "/home/joerg/fab-workspace/lfric_atm-full-debug-mpif90-gfortran/build_output/science/socrates/interface_core/socrates_bones.f90",
    "file_hash": 622851657,
    "symbol_defs": [
        "socrates_bones"
    ],
    "symbol_deps": [
        "rad_ccf",
        "realtype_rd",
        "scale_field",
        "scale_field_1d_layer",
        "scale_field_1d_tile",
        "scale_field_surf"
    ],
    "file_deps": [],
    "program_defs": [],
    "module_defs": [
        "socrates_bones"
    ],
    "module_deps": [
        "rad_ccf",
        "realtype_rd"
    ],
    "mo_commented_file_deps": [],
    "psyclone_kernels": {},
    "cls": "AnalysedFortran"
}

So scale_field is listed as dependency, but the analysis misses the fact that scale_field is a contained subroutine. Then it finds that scale_field is also a program and add it.
It seems correct that scale_field is not listed as symbol_defs, since it's not exported (as a contained subroutine).

• Only list symbols as symbols_deps if they are not available in the local scope.
• Except for the top level, do not add a program as a dependency