Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove silent downcasting from API method and refactor tests #73

Open
javihern98 opened this issue Feb 14, 2025 · 0 comments
Open

Remove silent downcasting from API method and refactor tests #73

javihern98 opened this issue Feb 14, 2025 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@javihern98
Copy link
Contributor

Overview

Issue #71 reduces the range of Pandas libraries used to 2.1.4-2.2 to ensure we can use the engine with APT packages. This change generated an exception related to the silent downcasting we use before visiting the interpreter, using both semantic analysis and run methods on API:

    with pd.option_context("future.no_silent_downcasting", True):
        result = interpreter.visit(ast)

When attempting to remove the silent downcasting, I find there is some issue in test 5 of the CASE tests (test_case_ds, parameter 5)

Image

Important

When solving this issue, double check you have installed pandas 2.1.4

Tasks to perform

  • Ensure all tests are using API methods run and semantic_analysis
  • Ensure all tests are working fine when removing the silent downcasting

Note

No tests should be added for this issue

@javihern98 javihern98 added the bug Something isn't working label Feb 14, 2025
@javihern98 javihern98 added this to the 1.1 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants