Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add components-configurations.sh #125

Open
ronald-cron-arm opened this issue Dec 18, 2024 · 3 comments · May be fixed by #151
Open

Add components-configurations.sh #125

ronald-cron-arm opened this issue Dec 18, 2024 · 3 comments · May be fixed by #151
Assignees
@Harry-Ramsey
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)

Comments

@ronald-cron-arm
Copy link
Contributor

ronald-cron-arm commented Dec 18, 2024 •
edited
Loading

Add component-configurations.sh in tests/scripts
Same components as in Mbed TLS but:

At time of writing: 12 components.
For build_tfm there is a dependency on Mbed-TLS/mbedtls#9879.

Components based on make should be adapted to CMake. Compilation flags don't have to stay exactly the same but the ones relevant to the component should be kept the same.

In components:

  • calls to ssl-opt.sh, compat.sh, context-info.sh and programs/test/selftest should be removed.
  • out of scope for this issue, calls to programs/test/cpp_dummy_build, run_demos.py, test_psa_constant_names.py and run-metatests.sh.
@ronald-cron-arm ronald-cron-arm added enhancement New feature or request size-s Estimated task size: small (~2d) labels Dec 18, 2024
@ronald-cron-arm ronald-cron-arm moved this to TF-PSA-Crypto all.sh components in Mbed TLS Epics Dec 18, 2024
@ronald-cron-arm ronald-cron-arm changed the title Add component-configurations.sh Add components-configurations.sh Dec 20, 2024
This was referenced Jan 2, 2025
Closed
Closed
Open
Open
@Harry-Ramsey Harry-Ramsey self-assigned this Jan 6, 2025
@Harry-Ramsey
Copy link
Contributor

Harry-Ramsey commented Jan 6, 2025 •
edited
Loading

I have managed to port some components over however TF-PSA-Crypto does not have a selftest.c file. Is this also to be removed from components?

Furthermore, are we still enabling the build_tfm component as TF-PSA-Crypto does not have a config for that either?

@ronald-cron-arm
Copy link
Contributor Author

I have managed to port some components over however TF-PSA-Crypto does not have a selftest.c file. Is this also to be removed from components?

Yes, we do not need calls to programs/test/selftest in TF-PSA-Crypto. The self tests are anyway executed in test suites. But in the case of calloc maybe, see comment in test_malloc_0_null(), to be checked.

@ronald-cron-arm
Copy link
Contributor Author

Furthermore, are we still enabling the build_tfm component as TF-PSA-Crypto does not have a config for that either?

Yes, I've created Mbed-TLS/mbedtls#9879 for the move of some crypto config files to TF-PSA-Crypto and updated the description of this issue with a mention to build_tfm and its dependency on Mbed-TLS/mbedtls#9879.

@ronald-cron-arm ronald-cron-arm moved this from TF-PSA-Crypto all.sh components to TF-PSA-Crypto all.sh 2 - misc in Mbed TLS Epics Jan 7, 2025
@Harry-Ramsey Harry-Ramsey linked a pull request Jan 13, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Harry-Ramsey Harry-Ramsey

Labels
enhancement New feature or request size-s Estimated task size: small (~2d)
Projects
Mbed TLS Epics
Status: TF-PSA-Crypto all.sh 2 - misc
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add various configuration components Harry-Ramsey/TF-PSA-Crypto
2 participants
@ronald-cron-arm @Harry-Ramsey