Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate monitor_subset() arguments #73

Open
jonathancallahan opened this issue Mar 19, 2019 · 0 comments
Open

deprecate monitor_subset() arguments #73

jonathancallahan opened this issue Mar 19, 2019 · 0 comments
Assignees
@spencerpease
Labels
enhancement
Milestone
PWFSLSmoke 1.3

Comments

@jonathancallahan
Copy link
Member

I think we should deprecate all of the arguments to monitor_subset() that could be used in monitor_filter() in an effort to push people toward dplyr-pipeline style.

Calling the function with any of these arguments should result in a warning message:

  • monitorIDs
  • stateCodes
  • countryCodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spencerpease spencerpease

Labels
enhancement
Projects
None yet
Milestone
PWFSLSmoke 1.3
Development

No branches or pull requests
2 participants
@jonathancallahan @spencerpease