Use map instead of mapValues/shuffle in XMLCoderElement.flatten #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 76.98% 76.97% -0.02%
==========================================
Files 38 38
Lines 2112 2111 -1
==========================================
- Hits 1626 1625 -1
Misses 486 486
Continue to review full report at Codecov.
|
MaxDesiatov
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
This is great, thank you @jsbean! Indeed, there was no point in shuffled() other than appeasing the type checker.
arjungupta0107
pushed a commit
to salido/XMLCoder
that referenced
this pull request
Jun 26, 2020
…Office#93) * Use map instead of mapValues in XMLCoderElement.flatten * Remove whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a
mapoverkey-valuepairs instead ofmapValuesalong withshuffled()when transforming attributes into aBox-ed representation withinXMLCoderElement.flatten().At first, I was wondering what the
shuffled()was for. I tried to get rid of it on its own, but the compiler didn't appreciate that very much when it came toKeyedStorage.init<S>(_ sequence: S) where S: Sequence, S.Element == (Key, Value). Could this be a moment of ambiguity between(Key,Value)and(key: Key, value: Value)?Ultimately,
mapValuesalone should do the trick, but I thought it might be nice to avoid another O(n) pass if not necessary.Did
shuffledhave any other purpose than juggling types with the compiler?