-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate lint stage to .travis.yml #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 702a1e9.
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=========================================
+ Coverage 76.93% 78.04% +1.1%
=========================================
Files 37 37
Lines 1812 2022 +210
=========================================
+ Hits 1394 1578 +184
- Misses 418 444 +26
Continue to review full report at Codecov.
|
hodovani
approved these changes
Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents linting stage from running multiple times in all parallel jobs. We're mostly going to develop with the latest version of Xcode, so we only care about linter and formatter warnings with that version. Thus, the linter stage runs first with the latest version, while actual tests run in parallel jobs of the next "test" stage.