Complete NodeManager
tests from decentralised nodes refactor
#642
Labels
development
Standard development
r&d:polykey:core activity 4
End to End Networking behind Consumer NAT Devices
Specification
In a rush to get #618 complete, we didn't finish or convert all the tests we wanted. Theses need to be completed but can be done along side manual integration testing with the testnet.
#618 (comment) contains a description of the tests that still need to be done. The tests already exist within the test files as
test.todo()
s.Additional context
Tasks
findNode
operations handle offline nodes/connection failures. Make sure that a single failing connection wont take up the full timeout of the process.syncNodeGraph
, connects to 2 seed nodes and check we discover all active nodes in the network. Include active connection and direct connection links.syncNodegraph
handles offline nodes - just checking if we can handle offline nodes for the initial connections. The other connections are done byfindNode
. Also check that including our ownNodeId
in the initial connections list wont break.refreshBucket
triggers afindNode
operation within that bucket. Not really worth the test.NodeGraph
updates when a connection is made.MDNS
functionality. On that note, we need a way to disable it for testing so it doesn't break thefindNode
tests. Maybe just mock it out for most tests.The text was updated successfully, but these errors were encountered: