-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Proxy
domain to use timedCancellable
#464
Comments
Looks ike the proxy domain is using a object map for tracking locking. We can switch this over to a |
The keepAliveTimeoutTime = 20000,
endTime = 1000,
punchIntervalTime = 1000,
keepAliveIntervalTime = 1000, These should be configurable from the config file. |
Don't directly import them from the config. I believe these are meant to be injected by |
It was either that or that |
Although, I do use some constants from |
Ok actually I remember now. The Parameters that are supposed to change due to runtime conditions are not supposed to be in |
So implementation is done by we have 1 more test to do here:
So at the very least 1 day for the reviewing everything, and 1 day to fix the above bug. |
@tegefaulkes make sure to update the spec with what has changed in the interface. That they all take |
Specification
The
Proxy
domain needs to be updated to usetimedCancellable
and better support cancellability. This means that any methods that create connections needs to support cancellation. Robust testing needs to be added to test if cancelled connections are gracefully handled from both the forward and reverse side of the connection.Additional context
timedCancellable
across the board to control how long side-effects are allowed to complete #450Tasks
Proxy
methods needs to support cancellation via the abort signalProxy
methods need to be updated to use thetimedCancellabe
decorator.Proxy
tests need to be expanded to test a wide range of cancellation and connection failure conditions.The text was updated successfully, but these errors were encountered: