Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to setup PATH during installation of Polykey #64

Open
1 task
sujaycarkey opened this issue May 22, 2024 · 5 comments
Open
1 task

Explain how to setup PATH during installation of Polykey #64

sujaycarkey opened this issue May 22, 2024 · 5 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation r&d:polykey:supporting activity Supporting core activity

Comments

@sujaycarkey
Copy link

sujaycarkey commented May 22, 2024

Procedural Documentation Tasks

  • Ensure that the Linux Instructions for Manual installation of PK are clear as to how to setup PATH during installation of PK.

Comment: This should be less of an issue now since we are also providing the npm install method which should bypass many of the PATH related configuration complications use can experience. However, even for this method, there's configuration requirements for npm that users must have already setup for the global install method to be seamless.

Describe the bug

While following the guide for installing Polykey on Bash terminal, I was running into an issue with @CryptoTotalWar where the path wasn't being found for the install, leading to the executable not being able to be started just by typing 'polykey' into the terminal.

To Reproduce

  1. ...
  2. ...
  3. ...

Expected behavior

Polykey should be added as a path, then should be able to be used as a command in the terminal.

Screenshots

image

image

Platform (please complete the following information)

  • Device: [HP Pavilion laptop]
  • OS: [Linux Mint]
  • Version [5.15.0-67-generic]

Additional context

Problem was fixed once I edited the path command to this instead of what was there:
echo 'export PATH=~/downloads/polykey:$PATH' >> ~/.bashrc && source ~/.bashrc

Notify maintainers

@sujaycarkey sujaycarkey added the bug Something isn't working label May 22, 2024
Copy link

linear bot commented May 22, 2024

@CMCDragonkai
Copy link
Member

Hi @sujaycarkey PK CLI will not add itself to the PATH as that's a user configuration of the operating system and not an application concern. This might be better explained in the docs. Perhaps @CryptoTotalWar can move to the docs.

In the future we may have some "installer" script that can be run.

@CMCDragonkai CMCDragonkai transferred this issue from MatrixAI/Polykey-CLI May 23, 2024
Copy link

linear bot commented May 23, 2024

@CMCDragonkai CMCDragonkai changed the title Pathing Issue with Polykey Install Guide Explain how to setup PATH during installation of Polykey Jun 4, 2024
Copy link
Member

Nix has a script installer - we could replicate this for different OSes, but users are recommended to read the script for installation of the CLI. However for non-technical users, it would have to be distributed through their app-distribution systems, like Mac App Store, or Windows system or OS package manager.

Creating a custom installer for a CLI tool seems overkill.

Copy link
Member

I would argue this issue can be solved with more documentation, and later we can scope out installer/scripts in the engineering team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation r&d:polykey:supporting activity Supporting core activity
Development

No branches or pull requests

3 participants