-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong artist info (and double notifications) on the home page. #45
Comments
Could I pick this and see if I can fix it by the weekend? Unless you've already started on this @Mar0xy |
Go ahead and try I haven't bothered trying to find a way to fix the artist stuff I had an idea in mind but didn't try it yet. |
@yashank09 any help is welcome 😄 If either of you wants some help feel free to ask! |
Sounds good! Let me look over it by the weekend and get back. |
Hello, could I please know how to get dev-tools opened up in the app? I tried the most common shortcuts but no luck. I would definitely need a bit more time on this than compared to you both. But since this is still a low priority, I would love to try it before reassigning. |
Hey @yashank09 , Sorry I had a busy weekend 😄.
You can do this in the There are about... 1000 ways to block devtools (even listen.tidal.com can do it) but the electron-code approach works flawlessly. And don't worry about the time it takes. It's a minor issue that I'm sure most can live with. It's noticeable for sure, but usually you aren't on the home page anyway. (and the workaround is really simple...) PS: make sure you use a window large enough to show tidal + devtools. |
@yashank09 Did you come around to this or would you like me to pick it up myself? |
@yashank09, I fixed the bug myself. It was causing other problems. You can look at this commit to see how I have done it. So.... Fixed in 2.2.2. Use your preferred update path and enjoy! |
When on the "home" page tidal-hifi 2.2.0 will still show the wrong artist info:
As this doesn't happen on the other pages (search, music lists, playlist, etc) this is marked as low priority at the moment as it shouldn't really have a big impact.
PS: Going to any other page in which the artist will be fetched correctly will send out an update to correct the wrong artist name.
The text was updated successfully, but these errors were encountered: