Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong artist info (and double notifications) on the home page. #45

Closed
Mastermindzh opened this issue Apr 25, 2021 · 8 comments
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Mastermindzh
Copy link
Owner

When on the "home" page tidal-hifi 2.2.0 will still show the wrong artist info:

image

As this doesn't happen on the other pages (search, music lists, playlist, etc) this is marked as low priority at the moment as it shouldn't really have a big impact.

PS: Going to any other page in which the artist will be fetched correctly will send out an update to correct the wrong artist name.

@stickyburn
Copy link

Could I pick this and see if I can fix it by the weekend? Unless you've already started on this @Mar0xy

@Mar0xy
Copy link
Contributor

Mar0xy commented Apr 26, 2021

Could I pick this and see if I can fix it by the weekend? Unless you've already started on this @Mar0xy

Go ahead and try I haven't bothered trying to find a way to fix the artist stuff I had an idea in mind but didn't try it yet.

@Mastermindzh
Copy link
Owner Author

@yashank09 any help is welcome 😄

If either of you wants some help feel free to ask!

@stickyburn
Copy link

Sounds good! Let me look over it by the weekend and get back.

@stickyburn
Copy link

Hello, could I please know how to get dev-tools opened up in the app? I tried the most common shortcuts but no luck.

I would definitely need a bit more time on this than compared to you both. But since this is still a low priority, I would love to try it before reassigning.

@Mastermindzh
Copy link
Owner Author

Mastermindzh commented May 3, 2021

Hey @yashank09 ,

Sorry I had a busy weekend 😄.
In Electron you have multiple screens and each has its own devtools kit included.
To open the kit you call:

WINDOWNAME.webContents.openDevTools();

You can do this in the app.on('ready'... block for the mainWindow 😄

There are about... 1000 ways to block devtools (even listen.tidal.com can do it) but the electron-code approach works flawlessly.

And don't worry about the time it takes. It's a minor issue that I'm sure most can live with. It's noticeable for sure, but usually you aren't on the home page anyway. (and the workaround is really simple...)

PS: make sure you use a window large enough to show tidal + devtools.
If the window is "too small" certain details disappear (like the album art image) so tidal-hifi can't display them either. Those are completely normal so either use a bigger window size (it remembers it after you change it) or ignore the missing album art ;)

@Mastermindzh
Copy link
Owner Author

@yashank09

Did you come around to this or would you like me to pick it up myself?

@Mastermindzh
Copy link
Owner Author

@yashank09, I fixed the bug myself. It was causing other problems. You can look at this commit to see how I have done it.

So....

Fixed in 2.2.2.

Use your preferred update path and enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants