Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator use newInstance method name #66

Closed
sla100 opened this issue Mar 26, 2023 · 0 comments · Fixed by #67
Closed

Generator use newInstance method name #66

sla100 opened this issue Mar 26, 2023 · 0 comments · Fixed by #67
Assignees
Labels
bug Something isn't working

Comments

@sla100
Copy link
Contributor

sla100 commented Mar 26, 2023

Describe the bug
When I used java-ts-gen i got factory method:

export declare class AppClass extends JavaClass {
  // ...
  public static newInstance(): Promise<App>;
  // ...
}

But regardles to documentation its name should be newInstanceAsync.

Environment

  • OS: Windows
  • Node.js version: 18.15.0
  • Java version: 17
  • Version of this package: 2.2.3

Additional context
TypescriptDefinitionGenerator.ts#L343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants