Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meta tag for algolia search #754

Closed
damithc opened this issue Mar 7, 2019 · 3 comments · Fixed by #757
Closed

Add meta tag for algolia search #754

damithc opened this issue Mar 7, 2019 · 3 comments · Fixed by #757
Labels
f-Search p.Low

Comments

@damithc
Copy link
Contributor

damithc commented Mar 7, 2019

Algolia team has asked if we can include the following meta tag in MarkBind sites that has Algoli plugin enabled.
<meta name="generator" content="markbind">
@damithc damithc added p.Low f-Search s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding labels Mar 7, 2019
@Xenonym
Copy link
Contributor

Xenonym commented Mar 7, 2019

We could just include the tag on all MarkBind generated pages anyway, since its part of HTML5.

We could also include the version number eg. <meta name="generator" content="MarkBind 1.19.2">.

@yamgent
Copy link
Member

yamgent commented Mar 7, 2019

We could just include the tag on all MarkBind generated pages anyway, since its part of HTML5.

We could also include the version number eg. <meta name="generator" content="MarkBind 1.19.2">.

Yes let's do that. We can do it for all pages regardless of whether they use Algolia or not.

@damithc
Copy link
Contributor Author

damithc commented Mar 7, 2019

We could just include the tag on all MarkBind generated pages anyway, since its part of HTML5.

We could also include the version number eg. <meta name="generator" content="MarkBind 1.19.2">.

I'm OK with that too 👍

@Xenonym Xenonym mentioned this issue Mar 7, 2019
Merged
@Xenonym Xenonym removed the s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding label Mar 7, 2019
yamgent pushed a commit that referenced this issue Mar 14, 2019
@Xenonym @yamgent
Add <meta name="generator"> tags to generated HTML (#757)
07814ff 
The Agolia team has requested that we add <meta name="generator">
(#754) tags to identify pages generated by MarkBind. Since this tag is
part of HTML5 [1] and can be used by other external providers to
identify MarkBind generated sites, we can include this tag in all
MarkBind pages. We can also include the version number to allow
tracking the use of different MarkBind versions, as other projects
have done [2, 3].

Let's include the <meta name="generator"> tag to identify MarkBind
pages, as well as including the version number to track the use of
different MarkBind versions.

[1]: https://www.w3.org/TR/html5/document-metadata.html#generator
[2]: hexojs/site#649
[3]: gatsbyjs/gatsby#8221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
f-Search p.Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add <meta name="generator"> tags to generated HTML
3 participants
@damithc @Xenonym @yamgent