-
consider adding a
.gitignoreto your root directory and adding.DS_Storeto line 1 to ignore.DS_Storefiles from your github add list. -
Great html! Your codebase uses semantic html and I can completely see your site based on reading your code!
-
Your whole site has a great sheen and polish to it. It feels quite professional. I love the smooth transitions and all the small details you covered.
-
Great work on your marvel api work! Very impressive!
-
Your CSS is very well organized and written. No suggestions!
-
Looking forward to your responsive layout!
-
Consider moving your transition and smoothing effects into a separate file to take up less room in your
main.js
| Incomplete | Does not Meet Expectations | Meets Expecatations | Exceeds Expectations | |
|---|---|---|---|---|
| Uses semantic markup for HTML and CSS, adhering to best practices | X | |||
| Uses Flexbox to create a multi-column layout | X | |||
| Is completely responsive | X | |||
| Includes separate HTML/CSS/JavaScript files | X | |||
| Sticks with the KISS (Keep It Simple Stupid) and DRY (Don't Repeat Yourself) principles | X | |||
| Uses JavaScript or jQuery for DOM manipulation | X | |||
| Includes the interactions listed under "Necessary Deliverables" | X | |||
| Is deployed online | X |