Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bz#1467504: Creating a Generic Catalog Item #462

Merged
merged 2 commits into from
Jul 28, 2017
Merged

Bz#1467504: Creating a Generic Catalog Item #462

merged 2 commits into from
Jul 28, 2017

Conversation

cbudz
Copy link
Contributor

@cbudz cbudz commented Jul 27, 2017

Hey Suyog,

I've added the required procedure on adding a generic catalog item Provisioning VMs guide, which you can find in the included files. While working on this, I did make an additional change of moving this item, and those for Ansible Playbook and Ansible Tower catalog items up a level in the index. My rational is that, since each of these is really its own unique workflow, they shouldn't be nested as subtopics under Creating a Catalog Item (that deal with different providers).

Let me know what you think.

-Chris

@miq-bot
Copy link
Member

miq-bot commented Jul 27, 2017

Checked commits cbudz/manageiq_docs@cf34cd9~...82a77f4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@cbudz cbudz requested a review from suyogsainkar July 27, 2017 18:44
@suyogsainkar
Copy link
Contributor

@cbudz Hey Chris, the changes look good to me. I suspect there is going to be a bit of an overhaul to the structure of Catalogs and Services for which I've started some work on already as part of another bug, and there is more to come. This is for the same reason you've identified yourself that each has its own unique flow and needs to better match the customer's use case. Merging this to master. Thanks, Suyog

@suyogsainkar suyogsainkar merged commit 53f679e into ManageIQ:master Jul 28, 2017
@cbudz cbudz added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants