-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate URLs for explorer screens #6724
Comments
@dwoodiwiss Can you be more specific about your needs please? |
@himdel Yes, the accordions for "Rates" & "Assignments" within: The default URL |
This issue will be resolved by finishing #6819. Non-explorer controllers already support |
closing in favor of #6819 |
Closing as #6819 is effectively implementing this. |
Final target: each independent screen should be accessible by URL
EDIT: Depends on (and is likely completed by) #6819
This is mostly true for non-explorer controllers, where we just do full page reloads,
and it's true for v2v as well (via hash urls).
But explorer screens share the same /explorer url, and while individual actions may have separate URLs, those urls sometimes only lead to ajax fragments, not full screens.
For lists and detail screens accessible by tree navigation, there is already some convention along the lines of
params[:accord]
,params[:tree]
,params[:id]
(sometimes a tree id) (also one:node_id
I think).I think we should definitely support
/foo/explorer?accord=vandt&id=v-123
, accordion + tree node,but also consider #6696, if the tree clearly implies the model, we may want to support raw ids.
Check:
catalog_controller.rb
chargeback_controller.rb
infra_networking_controller.rb
miq_ae_class_controller.rb
miq_ae_customization_controller.rb
miq_policy_controller.rb
mixins/manager_controller_mixin.rb
automation_manager_controller.rb
provider_foreman_controller.rb
mixins/vm_show_mixin.rb
vm_cloud_controller.rb
vm_infra_controller.rb
vm_or_template_controller.rb
ops_controller.rb
pxe_controller.rb
report_controller.rb
service_controller.rb
storage_controller.rb
(Also check
miq_template_controller.rb
andvm_controller.rb
, as those useVmCommon
like all theVmShowMixin
controllers above, but notVmShowMixin
itself.)Also look into exposing the tree as a separate screen, and a no-tree layout for the rest.
As for forms and other screens accessible only via toolbars, that may be harder,
in principle, if every
render :update
has a corresponding full screen version it should work,but it may be better to use something like #6327 to define new endpoints leading to such screens.
The text was updated successfully, but these errors were encountered: