Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate URLs for explorer screens #6724

Closed
16 tasks
himdel opened this issue Feb 28, 2020 · 7 comments
Closed
16 tasks

Separate URLs for explorer screens #6724

himdel opened this issue Feb 28, 2020 · 7 comments

Comments

@himdel
Copy link
Contributor

himdel commented Feb 28, 2020

Final target: each independent screen should be accessible by URL

EDIT: Depends on (and is likely completed by) #6819


This is mostly true for non-explorer controllers, where we just do full page reloads,
and it's true for v2v as well (via hash urls).

But explorer screens share the same /explorer url, and while individual actions may have separate URLs, those urls sometimes only lead to ajax fragments, not full screens.


For lists and detail screens accessible by tree navigation, there is already some convention along the lines of params[:accord], params[:tree],params[:id] (sometimes a tree id) (also one :node_id I think).

I think we should definitely support /foo/explorer?accord=vandt&id=v-123, accordion + tree node,
but also consider #6696, if the tree clearly implies the model, we may want to support raw ids.

Check:

  • catalog_controller.rb
  • chargeback_controller.rb
  • infra_networking_controller.rb
  • miq_ae_class_controller.rb
  • miq_ae_customization_controller.rb
  • miq_policy_controller.rb
  • mixins/manager_controller_mixin.rb
    • automation_manager_controller.rb
    • provider_foreman_controller.rb
  • mixins/vm_show_mixin.rb
    • vm_cloud_controller.rb
    • vm_infra_controller.rb
    • vm_or_template_controller.rb
  • ops_controller.rb
  • pxe_controller.rb
  • report_controller.rb
  • service_controller.rb
  • storage_controller.rb

(Also check miq_template_controller.rb and vm_controller.rb, as those use VmCommon like all the VmShowMixin controllers above, but not VmShowMixin itself.)

Also look into exposing the tree as a separate screen, and a no-tree layout for the rest.


As for forms and other screens accessible only via toolbars, that may be harder,
in principle, if every render :update has a corresponding full screen version it should work,
but it may be better to use something like #6327 to define new endpoints leading to such screens.

@himdel himdel self-assigned this Feb 28, 2020
@himdel himdel mentioned this issue Apr 3, 2020
8 tasks
@h-kataria h-kataria mentioned this issue Apr 3, 2020
13 tasks
@dwoodiwiss
Copy link

I'm not sure if the following items would be contained within the work for chargeback_controller.rb, but the need for the following has become quite important to our team at the moment.

Rates Tab
/chargeback/explorer#/
image

Assignments Tab
/chargeback/explorer#/
image

@himdel
Copy link
Contributor Author

himdel commented Apr 24, 2020

@dwoodiwiss Can you be more specific about your needs please?
Are we talking just the active accordion?

@himdel himdel removed their assignment Apr 24, 2020
@dwoodiwiss
Copy link

@himdel Yes, the accordions for "Rates" & "Assignments" within:
Overview > Chargeback

The default URL /chargeback/explorer#/ already lands on the "Reports" accordion, but it would be nice to capture deep linking to that also, in case things change.

@himdel
Copy link
Contributor Author

himdel commented Apr 24, 2020

This issue will be resolved by finishing #6819.

Non-explorer controllers already support /show_list/, /show/:id, /new, /edit/:id when appliable.

@h-kataria
Copy link
Contributor

closing in favor of #6819

@Fryguy Fryguy reopened this Apr 30, 2020
@Fryguy
Copy link
Member

Fryguy commented Apr 30, 2020

Reopening this as the feature described here is different from the one described in #6819, even though #6819 will effectively solve this one

@Fryguy Fryguy added this to the Kasparov milestone Apr 30, 2020
@chessbyte chessbyte removed this from the Kasparov milestone Jul 28, 2020
@Fryguy Fryguy added the size/xl label Nov 1, 2021
@Fryguy
Copy link
Member

Fryguy commented Nov 1, 2021

Closing as #6819 is effectively implementing this.

@Fryguy Fryguy closed this as completed Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants