Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.1 support #543

Closed
cben opened this issue Feb 23, 2022 · 1 comment · Fixed by #549
Closed

Ruby 3.1 support #543

cben opened this issue Feb 23, 2022 · 1 comment · Fixed by #549

Comments

@cben
Copy link
Collaborator

cben commented Feb 23, 2022

  • it's not currently in test matrix (ruby-head is 3.2-to-be but not treating it as blocker)
  • Locally with 3.1.0 on linux, bundle install works but tests fail with:
    File does not exist: net/smtp
    
    Apparently spun out to 'net-smtp' gem. Not sure why we depend on it (real fix probably belongs in some library we depend on that imports it).
  • Tests print many deprecations.
@cben
Copy link
Collaborator Author

cben commented Mar 5, 2022

Currently the only deprecations message I see in 3.1 runs is:

/Users/runner/hostedtoolcache/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/httpclient-2.8.3/lib/httpclient/ssl_config.rb:370: warning: assigned but unused variable - pathlen
/Users/runner/hostedtoolcache/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/httpclient-2.8.3/lib/httpclient/ssl_config.rb:51: warning: method redefined; discarding old initialize
/Users/runner/hostedtoolcache/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/httpclient-2.8.3/lib/httpclient/ssl_config.rb:58: warning: method redefined; discarding old add_cert
/Users/runner/hostedtoolcache/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/httpclient-2.8.3/lib/httpclient/ssl_config.rb:58: warning: method redefined; discarding old add_file
/Users/runner/hostedtoolcache/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/httpclient-2.8.3/lib/httpclient/ssl_config.rb:58: warning: method redefined; discarding old add_path

which is nothing we can fix here. I guess I saw more in the past and they got fixed in various gems? 🤷

@cben cben closed this as completed in #549 Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant