Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check #170

Closed
GKTheOne opened this issue May 10, 2016 · 10 comments
Closed

Health check #170

GKTheOne opened this issue May 10, 2016 · 10 comments

Comments

@GKTheOne
Copy link

Support for the /healthz path?

@simon3z
Copy link
Collaborator

simon3z commented May 10, 2016

Support for the /healthz path?

@GKTheOne that would be nice (and easy to implement). 👍 from me.

@GKTheOne
Copy link
Author

I'll work on a PR soon(-ish) unless someone beats me to it. (Warning: I've only been doing ruby for less than a week)

@simon3z
Copy link
Collaborator

simon3z commented May 10, 2016

I'll work on a PR soon(-ish) unless someone beats me to it. (Warning: I've only been doing ruby for less than a week)

@GKTheOne are you planning to support also ping and ready? Not sure what's the exact difference between the three (maybe they're all there just for backward compatibility?)

cc @moolitayer

@moolitayer
Copy link
Collaborator

@GKTheOne could you please add a link in this issue's first comment to k8s docs on relevant api bits?

@abonas
Copy link
Member

abonas commented May 10, 2016

@GKTheOne could you please add a link in this issue's first comment to k8s docs on relevant api bits?

+1

Is this about /healthz for kubelet or containers health check?
generally speaking, a PR on health check is welcome

@GKTheOne
Copy link
Author

I was thinking about just the apiserver /healthz endpoint. Mainly as a simple availability check.

However after a quick google turned up nothing explicit documentation-wise, and based on @simon3z and @abonas comments, I'm starting to think a) /healthz will probably be deprecated, or at least is 'private', and b) you all have bigger ideas on 'health check' 😃

I'll do some digging this weekend and see what turns up.

@simon3z : What do you mean with ping and ready? I'm not aware of a ready endpoint, and the only ping endpoint I know of is /healthz/ping. But I still haven't looked properly at the exec-healthz code so if the answer's there then don't worry about answering. 😄

@abonas : Can you expand on what you mean re: "health check"? I'm thinking that a /healthz kubelet check could be done by simple http(s) checks (after getting the node list via kubeclient 😄 ), and a containers health check would also be done by other methods ... but I don't know what you're thinking.

Cheers,

@simon3z
Copy link
Collaborator

simon3z commented May 13, 2016

@simon3z : What do you mean with ping and ready? I'm not aware of a ready endpoint, and the only ping endpoint I know of is /healthz/ping. But I still haven't looked properly at the exec-healthz code so if the answer's there then don't worry about answering.

@GKTheOne:

# curl -k https://localhost:8443
{
  "paths": [
    ...
    "/healthz",
    "/healthz/ping",
    "/healthz/ready",
    ...
  ]
}

@abonas
Copy link
Member

abonas commented May 15, 2016

@abonas : Can you expand on what you mean re: "health check"? I'm thinking that a /healthz kubelet check could be done by simple http(s) checks (after getting the node list via kubeclient ), and a containers health check would also be done by other methods ... but I don't know what you're thinking.

@GKTheOne:
http://kubernetes.io/docs/user-guide/liveness/
although it seems that it should be self implemented already by including it in the pod definition (and making sure the status/response is read)

@GKTheOne
Copy link
Author

Thanks for that. I'll be a bit busy for the next couple of days (2-3), but I'll get back to this then.

@GKTheOne
Copy link
Author

GKTheOne commented Jul 9, 2019

n/a

@GKTheOne GKTheOne closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants