Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data of the independent ckb-indexer #91

Closed
Keith-CY opened this issue Jan 4, 2023 · 5 comments
Closed

Remove data of the independent ckb-indexer #91

Keith-CY opened this issue Jan 4, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Jan 4, 2023

CKB indexer of CKB node has been used since [email protected](https://github.com/nervosnetwork/neuron/releases/tag/v0.106.0) and the data of indexer are stored in a new directory(inside ckb directory).

However, data of the deprecated independent ckb indexer have not been removed and they cannot be cleared by clear cache.

To remove the outdated data, Neuron should add a task to check and remove them.

@Keith-CY Keith-CY added the enhancement New feature or request label Jan 4, 2023
@yanguoyu
Copy link

yanguoyu commented Jan 5, 2023

Should we add choose for users to delete, or delete indexer data by default? @Keith-CY

@Keith-CY
Copy link
Member Author

Keith-CY commented Jan 5, 2023

Should we add choose for users to delete, or delete indexer data by default? @Keith-CY

I think it's safe to delete them because [email protected] doesn't have an independent ckb indexer, so the data will not be used by any service. If the user runs ckb indexer by own, the indexer data will be stored elsewhere.

Namely, the indexer data is only accessible to the independent ckb indexer inside Neuron.

@yanguoyu
Copy link

yanguoyu commented Jan 6, 2023

@yanguoyu yanguoyu moved this from Todo to QA in Nervos Wallet/Explorer Jan 6, 2023
@Keith-CY
Copy link
Member Author

Sorry for adding a new detail, a precondition is expected to be added that the removal of old data should only be executed after the migration is fulfilled(the new path was set).

@yanguoyu
Copy link

Sorry for adding a new detail, a precondition is expected to be added that the removal of old data should only be executed after the migration is fulfilled(the new path was set).

Add this with nervosnetwork/neuron@2c876c0

@Danie0918 Danie0918 moved this from QA to Pre-release in Nervos Wallet/Explorer Feb 15, 2023
@Danie0918 Danie0918 added this to Neuron Feb 26, 2023
@Danie0918 Danie0918 moved this to 🚩Pre-release in Neuron Feb 26, 2023
@github-project-automation github-project-automation bot moved this from 🚩Pre Release to ✅ Done in Neuron Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Status: Pre-release
Development

No branches or pull requests

2 participants