V3 implementation #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
requested changes
Dec 16, 2018
There was a problem hiding this comment.
Let's add a CHANGELOG.md
# 3.0.0 - *upcoming*
- Now compatible with `markdown@todo` and Python 3
- TODO: What was removed, etc
# 2.x
https://github.com/MadLittleMods/markdown-icons/tree/v2
- Legacy version for `markdown@todo` and Python 2.7x
Let's also add a .gitlab-ci.yml for CI testing and deployment to PyPI. CI/CD-only project setup on GitLab, https://gitlab.com/MadLittleMods/markdown-icons
|
|
||
| #### No prefix (just in case you couldn't figure it out :P): | ||
| This isn't suggested, as it will take over the already built in HTML Entities | ||
| ```Python |
| ``` | ||
| md = markdown.Markdown(extensions=['iconfonts(prefix=)']) | ||
| converted_text = md.convert(text) | ||
| md = markdown.Markdown(extensions=[IconFontsExtension()]) |
There was a problem hiding this comment.
Seems like we could keep converted_text = md.convert(text) here
| #### `prefix_base_pairs` option | ||
|
|
||
| The `prefix_base_pairs` option allows for multiple prefix-base pairs to be specified, to allow you to support both Bootstrap 3/Glyphicon and FontAwesome icons | ||
|
|
||
| ##### In Python: | ||
| ``` | ||
| ``` |
|
|
||
| # Register the global one | ||
| self.add_inline(md, 'iconfonts', IconFontsPattern, icon_regex, config) | ||
| current_prio = 10 |
There was a problem hiding this comment.
Let's add a comment here to explain what this does.
Is this a standard pattern for other extensions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First working version of V3.
Fix #10