Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map shrink in MUME browser client #10

Open
co1191 opened this issue Feb 17, 2024 · 5 comments
Open

Map shrink in MUME browser client #10

co1191 opened this issue Feb 17, 2024 · 5 comments

Comments

@co1191
Copy link

co1191 commented Feb 17, 2024

When using the browser MUME client (I check in at work and on my iPad often), whenever a long line of text occurs, the map shrinks. It does not stay stretched back again if dragged back open. I only noticed this happening recently and I have reload the game to get it back to normal.

@Tiger-Tom
Copy link
Contributor

It seems like this is called by the ResizeObserver calling handleSizeChange().
Removing this seems to fix this problem.

Additionally, the ResizeObserver seems to cause crashes (at least on my machine, Firefox on Linux).
Resizing the window sometimes results in an error "ResizeObserver loop completed with undelivered notifications", and after that the ResizeObserver stops working, resulting in the map being resizable.

I do not know if the ResizeObserver has an actual use; I cannot think of one but it has to be in the code for a reason. I might make a pull request later removing it and adding more details about these problems and we'll see where that goes.

@Tiger-Tom
Copy link
Contributor

I propose having the whitespace wrap behavior as an option in the "Options" menu, however having it disabled would result in the same map-shrink behavior as before, so that would need to be addressed as well.

@Tiger-Tom
Copy link
Contributor

Hmm, looking at #8 it seems that no nowrap is necessary for MUME to detect proper terminal dimensions upon resizing the map. Not sure where to go from here.

@nschimme
Copy link
Contributor

Perhaps some way to lock the screen unless trying to resize?

@Tiger-Tom
Copy link
Contributor

Hmm, now I'm having trouble recreating the resizing issue, even on the main site. I still get errors about the ResizeObserver, but the text wraps now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants