Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching the mp3 of a recording which is divided into multiple subtracks #177

Closed
sertansenturk opened this issue Feb 4, 2015 · 3 comments
Milestone

Comments

@sertansenturk
Copy link
Contributor

When there are multiple performances in a audio track, we have divided the track into "sub"-recordings. One example is the track 14a,b,c in this release: https://musicbrainz.org/release/172af7d8-9817-49ab-8f1d-e7593984b8ad.

Currently when we attempt to download the mp3, we will only be able to download it for the first subtrack and the process will fail for the rest. Moreover we have to think how to the mp3 and how to store the related metadata in the mp3 after the download problem is solved.

I can provide all the fails while I recheck the collection as explained in #172.

@sertansenturk
Copy link
Contributor Author

One thing we can do is to edit the release metadata and have all the tracks to direct to the same recording [mbid]. This way when we request the recording we will ensure we get the track and it won't require you to do sth extra. It also makes sense from the MusicBrainz point of view since they are actually the same track (yet they were written separately in the album cover)

When we are request the release (if there's any function for such), we can just give the users unique mbids/ unique mp3s. It will only bring extra checking if two different masters are in the same release (issue #181 )

I am starting to put a list for all such releases, I can modify them according to your reply

@alastair alastair modified the milestone: Backend Feb 26, 2015
@alastair
Copy link
Member

This is a good idea, it sounds like a suitable solution. If you want to, you could double check with the musicbrainz guys, but also fine if you just go for it.

@sertansenturk
Copy link
Contributor Author

I got clarification from the MusicBrainz people (reosarevok to be specific). She/he said that dividing the tracks into 14a,b,c, is wrong since it is a single file. We should merge them in the release, open a new recording and relate the new recording to the current recordings pointed by 14a, 14b and 14c with a "compiles" relationship. According to reosarevok "[it] makes sense here since they're different works for each"

This arrangement solve this issue without a need to change the Dunya structure and we can still keep the work relationships etc. neatly. Except we might need to check if a recording has the "compiles" relationship with another recording and fetch the work relationships in the subrecording too.

I am now going through all the releases now to find such cases and fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants