Infinite recursion in basic exception handler

[jolting]

mrpt/libs/core/src/exceptions.cpp

Line 95 in 6cf7cd2

ret = e.what();

This should be

const auto* ecb = dynamic_cast<const ExceptionWithCallBackBase*>(&e);
if(ecb)
{
  ret = ecb->originalWhat;
}
else
{
  ret = e->what();
}

Since m_what is empty.

call exception_to_str

mrpt/libs/core/src/exceptions.cpp

Line 105 in 78c8f30

std::string mrpt::exception_to_str(const std::exception& e)

call impl_excep_to_str

mrpt/libs/core/src/exceptions.cpp

Line 51 in 78c8f30

void impl_excep_to_str(

call basic version

mrpt/libs/core/src/exceptions.cpp

Line 100 in 78c8f30

ret = e.what();

call e.what(), m_what is still empty

mrpt/libs/core/include/mrpt/core/exceptions.h

Line 95 in 78c8f30

if (m_what.empty()) m_what = mrpt::exception_to_str(*this);

repeat steps 1-4.

[jolting]

Potential fix:
https://github.com/jolting/mrpt/tree/infiniteExceptions

[jlblancoc]

Wow!! Excellent finding.