Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrpt: build failure with latest libjsoncpp #1118

Closed
LocutusOfBorg opened this issue Dec 4, 2020 · 5 comments · Fixed by #1121
Closed

mrpt: build failure with latest libjsoncpp #1118

LocutusOfBorg opened this issue Dec 4, 2020 · 5 comments · Fixed by #1121

Comments

@LocutusOfBorg
Copy link

Hello, looks like the new libjsoncpp is making mrpt FTBFS

[ 22%] Building CXX object libs/serialization/CMakeFiles/serialization.dir/src/CSchemeArchiveBase.cpp.o
cd /mrpt-2.1.4/obj-x86_64-linux-gnu/libs/serialization && /usr/bin/c++ -Dserialization_EXPORTS -I/usr/include/suitesparse -I/mrpt-2.1.4/libs/serialization/src -I/mrpt-2.1.4/libs/serialization/include -I/mrpt-2.1.4/libs/rtti/include -I/mrpt-2.1.4/libs/core/include -I/mrpt-2.1.4/obj-x86_64-linux-gnu/include/mrpt-configuration -I/mrpt-2.1.4/libs/typemeta/include -isystem /usr/include/jsoncpp -g -O2 -fdebug-prefix-map=/mrpt-2.1.4=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -O3 -DNDEBUG -fPIC -Wall -Wabi=11 -Wno-long-long -Wno-variadic-macros -Wshadow -Wreturn-local-addr -Werror=return-local-addr -Wno-ignored-attributes -Wno-int-in-bool-context -Wno-write-strings -Wreturn-type -Werror=return-type -Wformat -Werror=format-security -Wextra -Wtype-limits -Wcast-align -Wparentheses -Wno-unused-parameter -mtune=native -O3 -msse2 -fPIC -std=gnu++17 -o CMakeFiles/serialization.dir/src/CSchemeArchiveBase.cpp.o -c /mrpt-2.1.4/libs/serialization/src/CSchemeArchiveBase.cpp
In file included from /mrpt-2.1.4/libs/serialization/src/CSchemeArchive.cpp:13:
/mrpt-2.1.4/libs/serialization/include/mrpt/serialization/CSchemeArchive.h: In instantiation of 'mrpt::serialization::CSchemeArchiveBase& mrpt::serialization::CSchemeArchive<SCHEME_CAPABLE>::operator=(std::nullptr_t) [with SCHEME_CAPABLE = Json::Value; std::nullptr_t = std::nullptr_t]':
/mrpt-2.1.4/libs/serialization/include/mrpt/serialization/CSchemeArchive.h:73:43:   required from here
/mrpt-2.1.4/libs/serialization/include/mrpt/serialization/CSchemeArchive.h:76:9: error: use of deleted function 'Json::Value::Value(std::nullptr_t)'
   76 |   m_val = val;
      |   ~~~~~~^~~~~
In file included from /usr/include/jsoncpp/json/reader.h:11,
                 from /usr/include/jsoncpp/json/json.h:11,
                 from /mrpt-2.1.4/libs/serialization/src/CSchemeArchive.cpp:18:
/usr/include/jsoncpp/json/value.h:345:3: note: declared here
  345 |   Value(std::nullptr_t ptr) = delete;
      |   ^~~~~
make[4]: *** [libs/serialization/CMakeFiles/serialization.dir/build.make:111: libs/serialization/CMakeFiles/serialization.dir/src/CSchemeArchive.cpp.o] Error 1
make[4]: *** Waiting for unfinished jobs....

Can you please have a look?
thanks

@jlblancoc
Copy link
Member

Awesome, that explains #1116 .
I'll take a look now that we know where's the actual problem.

@jlblancoc jlblancoc added this to the Release v2.1.5 milestone Dec 5, 2020
@LocutusOfBorg
Copy link
Author

thanks!

@LocutusOfBorg
Copy link
Author

btw I saw some package on mentors.debian.org, but it has disappeared... do you need somebody to upload the fix?

@jlblancoc
Copy link
Member

Thanks! It was a first test, but now it's already submitted to mentors again. If you want to check and upload it, it would be fantastic 👍
I just finished uploading it, it will appear in mentors within minutes...

@LocutusOfBorg
Copy link
Author

uploaded thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants