From 9a1e6f6a767bf6edd4ab78c80bd6e4b366e193db Mon Sep 17 00:00:00 2001 From: Jose Luis Blanco-Claraco Date: Sun, 2 Mar 2025 00:23:43 +0100 Subject: [PATCH] Fix clang-tidy warnings in LockHelper --- libs/core/include/mrpt/core/lock_helper.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/core/include/mrpt/core/lock_helper.h b/libs/core/include/mrpt/core/lock_helper.h index 57ed481b0a..41540b25ea 100644 --- a/libs/core/include/mrpt/core/lock_helper.h +++ b/libs/core/include/mrpt/core/lock_helper.h @@ -22,7 +22,7 @@ class LockHelper using Tnc = std::remove_const_t; public: - LockHelper(const Tnc* l) : l_{const_cast(l)} { l_->lock(); } + explicit LockHelper(const Tnc* l) : l_{const_cast(l)} { l_->lock(); } ~LockHelper() { if (l_) l_->unlock(); @@ -31,11 +31,11 @@ class LockHelper LockHelper(const LockHelper& o) = delete; LockHelper& operator=(const LockHelper& o) = delete; - LockHelper(LockHelper&& o) : l_{o.l} { o.l = nullptr; } + LockHelper(LockHelper&& o) : l_{o.l_} { o.l_ = nullptr; } LockHelper& operator=(LockHelper&& o) { - l_ = o.l; - o.l = nullptr; + l_ = o.l_; + o.l_ = nullptr; return *this; }