New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing object does not check for start of string #43

Open

gfischershaw opened this issue Sep 10, 2020 · 0 comments

gfischershaw commented Sep 10, 2020

JSONValue::Parse()

// We want a string now...
std::wstring name;
if (!JSON::ExtractString(&(++(*data)), name))
{
FREE_OBJECT(object);
return NULL;
}

The code assumes that it has run into a quote char and extracts a string, but it never actually looks at what char it encountered.

BTW: The code within the "if {...}" should just be a "break;" and centralize the error cleanup. That is what the compiler is doing anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment