Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference logger is no longer used #962

Closed
tsalo opened this issue Aug 4, 2023 · 0 comments · Fixed by #965
Closed

Reference logger is no longer used #962

tsalo opened this issue Aug 4, 2023 · 0 comments · Fixed by #965
Labels
bug issues describing a bug or error found in the project

Comments

@tsalo
Copy link
Member

tsalo commented Aug 4, 2023

Summary

The references in the decision tree JSON files are currently printed out with the references logger, but that was removed a bit before the DTM branch was merged. We can drop the RefLGR stuff, along with the references field of the decision tree JSON files, and just use \\citep{@bibtex} as in the reporting logger messages. The only potential issue is that the BibTeX entries would need to already be present in the boilerplate BibTeX file.

Additional Detail

Next Steps

  1. Remove mentions/uses of RefLGR throughout tedana.
  2. Add references to the report field of the decision tree JSONs as BibTeX citations.
  3. Remove the references field.
    • What if we made the references field a list of BibTeX entries somehow, and then injected that into the boilerplate as we built the full references list?
  4. Update the decision tree JSON documentation.
@tsalo tsalo added the bug issues describing a bug or error found in the project label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues describing a bug or error found in the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant