Consider updating required status checks

[emdupre]

Summary

From #503, commits with [skip-ci] (such as those from the all-contributors bot) won't trigger merge coverage. Since merge coverage is a necessary check, the resulting PRs will never show as ready to merge. It would be nice if required checks weren't required when skip-ci was included.

Additional Detail

Here's a little more information from CircleCI on what a [skip ci] tag does: https://circleci.com/docs/2.0/skip-build/

Next Steps

It looks like a more granular solution is on CircleCI's radar, but for now the best solution might be to update our required status checks from coverage to the integration tests.

[tsalo]

The coverage step passes even when the report actually fails to upload, so it generally only fails if one or more of the integration and unit tests fail. Given that flaw, I agree that we should switch our required checks to the actual tests, but I think those should probably include the unit tests as well as the integration tests.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to tedana:tada: !

[jbteves]

Ah yes, this is the problem with #580. I think we should just require the tests for simplicity, though it's not strictly necessary.

[tsalo]

Are folks okay with me just making this happen? It's very easy to do in the GitHub settings.

[jbteves]

@tsalo I say go for it and if something bad happens feel free to blame me.

[tsalo]

Sounds good. The integration and unit tests are now required, and merge coverage is not.