-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get RICA to work with tedana_reclassify #57
Comments
I've had a look at It looks like passing the What do you think @handwerkerd @jbteves? |
Eneko, I implemented a solution for you and then totally forgot to tell you, sorry. There are a few ways to supply the components now:
|
This is great. Thank you Josh! I will try to develop the new downloading function in Rica sometime this week. |
Summary
When Decision Tree Modularization is merged, the interface with RICA will break. The current function RICA uses to manually change classifications will be removed and these changes will happen through a new workflow
tedana_reclassify
It would be good to make sure RICA works with both version before that major change is mergedAdditional Detail
RICA should be able to interface with tedana through
tedana.workflows.tedana_reclassify.post_tedana
. In the new version, instead of inputting multiple filenames, it takes a filename registry calleddesc-tedana_registry.json
orregistry.json
RICA should be able to use the same system where users select a directory to use, but, if the registry exists, use the registry to identify file names and the runpost_tedana
otherwise just run the current I/O code which should keep for older versions of tedana.With the newer version, the component table will keep existing
classification_tags
for each component and also add amanual reclassify
tag. Additionally the component_status_table will add columns for each component showing how components where changed with reclassification so that provenance of manually will be fully documented.Additionally, the file registry should work with relative paths so it would be possible to have RICA output a new denoised dataset to a new output directory and the new registry in that output directory will be able to reference back to the original files that weren't changed and didn't need to be copied.
Next Steps
The text was updated successfully, but these errors were encountered: