-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax highlighting differences between this fork and the original repository #27
Comments
In short, yes. To explain further, "variables", in my fork, should always be shown as the "normal" color. The blue that was used before is reserved for either "types" or "properties/fields" (slightly different shade).
That is often the case. When I make a change, I always make sure to use it myself for a while before pushing it. If I forget about it after a while, it means it's fine, if I don't it means it needs to be changed (which is why #22 is still not merged). Another thing to note is that I mostly use treesitter so I have a tendency to use that as a "source of truth". I've found treesitter to be a lot more consistent across languages than most syntax files. |
For what it's worth, I've tested other themes and they seem to follow the behavior of the original repository. I've also noticed that if I start vim on a different colorscheme, switch to this colorscheme, and then back to the original, the syntax highlighting of the original colorscheme is affected: (Original gruvbox on left, gruvbox after |
I appreciate the effort! |
I've tried this with this gruvbox theme (you didn't give information on which gruvbox theme you are using).
|
Apologies, the issue appears across every colorscheme after loading The colorscheme mangling does appear to be a Vim8 bug unfortunately. There's a solution in that issue here. Thanks for the assistance! |
I saw that some colors were updated to match the definitions in the ayu-colors repository. I'm not sure if this change is due to that, but I've noticed differences in syntax highlighting between this fork and the original:

(this fork on right, old on left)
Notice the difference in which variables recieve the blue color. Perhaps I'm just used to it, but I find the old highlighting to be easier to parse.
Was this intentional?
Sorry if this overlaps with the other syntax highlighting issues that are open.
The text was updated successfully, but these errors were encountered: