Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade to comply Meteor v0.8.3 #50

Open
menway opened this issue Jul 31, 2014 · 16 comments
Open

Please upgrade to comply Meteor v0.8.3 #50

menway opened this issue Jul 31, 2014 · 16 comments
Labels

Comments

@menway
Copy link

menway commented Jul 31, 2014

Hi Austin, thanks for your hard work on jquery-datatables package. It's very awesome :-) Since Meteor version 0.8.3 has just released, could you please help upgrade jquery-datatables for the new version? Thank you.

Following is my current temporary workaround F.Y.I. For maintantance considerations, I wrote these codes in an additional file, rather than modifying the existing codes in the package.

# patch for jquery-datatables v1.0.5 for Meteor v0.8.3

DataTableComponent.prototype.oldRendered = DataTableComponent.prototype.rendered

DataTableComponent.prototype.rendered = ->
    that = this
    setTimeout ->
        that.oldRendered()
    , 0
    return

DataTableComponent.prototype.setQuery = (query) ->
    if @subscription
        @prepareQuery() unless @query
        #unless @query() is query
        if true
            @query query
            @rendered()

Template.DataTable.created = ->
    @.__component__ = @.__view__
    dataTableInstance = new DataTableComponent @
@gjolund
Copy link
Contributor

gjolund commented Jul 31, 2014

@menway thanks for taking the time to help convert to v0.8.3

However I am waiting on the MDG team finalizing their component structure and animation hooks prior to porting jquery-datatables, due to the the fact that I know it will be a breaking change, and I want to limit the number of times I refactor the existing apis.

Have you experienced any other issues while using this package?

@adamwong246
Copy link

Am I to understand that meteor-jquery-datatables does not yet support meteor v0.8.3? If so, which version of meteor should I be using?

@adamwong246
Copy link

To answer my own question, I found can only run meteor-jquery-datatables on meteor v.0.8.2.

@carlwithac
Copy link

With menways patch code it "works" on v0.8.3, only had issues when I didn't use a subscription as dataset

@pajooh
Copy link

pajooh commented Aug 12, 2014

even by applying @menway 's patch, i'm getting :
Exception from Deps recompute function: Error: Can't call non-function: undefined
i see that this recompute error also is reported in #40, witch i think is not related to my case
my basic configuration object looks like this:

// as a template helper
  collectionDT: function () {
    return {
      id: "collection-data-table",
      columns: [{
        title: "Title",
        data: "title"
      },{
        title: "Description",
        data: "description"
      }],
      subscription: "all_docs"
    }
  }

// server side
  var dataTable = new DataTableComponent({
    subscription: "all_docs",
    collection: SomeCollection,
  })
  dataTable.publish()

@dohomi
Copy link

dohomi commented Aug 19, 2014

Hi guys,
any idea where the error belongs? Meteor 0.9 rc9 is out and I would love to use this package. But due to coffee script I am not the right guy for tracing the error.

@ouuyeah
Copy link

ouuyeah commented Sep 4, 2014

Hey guys show some love for 0.9 version :D

@chadrik
Copy link
Contributor

chadrik commented Sep 4, 2014

Hi all,
I'm the senior dev at Luma Pictures, the company maintaining this project. @austinrivas will be off the project for the foreseeable future, but we are hoping to have a new dev assigned to this in the next month or so. In the meantime, if someone wants to fork this and carry the baton, that would be awesome. Don't worry, the project is not dead, it's just stalled for the moment.

On a slightly related note, are there others like @dohomi who feel that CoffeeScript is generally a turn-off for contributing to or troubleshooting this project?

@pajooh
Copy link

pajooh commented Sep 4, 2014

@chadrik i feel like @dohomi about coffeescript!

@ouuyeah
Copy link

ouuyeah commented Sep 5, 2014

I feel like you about coffee guys

@stbaer
Copy link

stbaer commented Sep 7, 2014

-1 for coffeescript

@rwillmer
Copy link

-1 for coffeescript as the only documented option; both javascript and coffeescript examples would be ideal, but if only one, please use javascript; jquery-datatables is hard enough to configure without having to learn a new language to do it.

@dohomi
Copy link

dohomi commented Sep 23, 2014

everybody who likes to use datatables try out https://github.com/ephemer/meteor-reactive-datatables it works quite neat on current meteor version.

@menway
Copy link
Author

menway commented Oct 27, 2014

@dohomi +1 for ephemer:reactive-datatables

@dandv
Copy link
Contributor

dandv commented Oct 29, 2014

Hey @austinrivas - Meteor 1.0 was released today!

@dandv
Copy link
Contributor

dandv commented Nov 7, 2014

@menway: you developed meteor-jquery-datatables. Are you recommending ephemer's package instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests